Problem/Motivation

Some of the assertions in AssertContentTrait have the same name as deprecated assertions, which is confusing.

For instance:

  1. \Drupal\KernelTests\AssertContentTrait::assertLinkByHref()
  2. \Drupal\FunctionalTests\AssertLegacyTrait::assertLinkByHref()

Proposed resolution

Add content to AssertContentTrait ones? For example: assertLinkByHref() to assertContentLinkByHref()

Remaining tasks

Needs discussion

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3142806-4.patch143.39 KBmohrerao

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Parent issue: » #3027952: [Plan] Remove the usage of deprecated methods in tests
mohrerao’s picture

mohrerao commented
Assigned: Unassigned » mohrerao
Status: Active » Needs work

On it

mohrerao’s picture

mohrerao commented
Assigned: mohrerao » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3142806-4.patch143.39 KB

Adding patch for replacing assertLinkByHref() to assertContentLinkByHref() and assertNoLinkByHref() to assertContentNoLinkByHref()

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Issue summary: View changes

@mohrerao, thanks!

But I should say it clearly that this issue is not ready to take actions. Sorry, it's my bad.

The proposed resolution is a BC change, a BC layer is required. And most importantly, not sure if we are going to do it.

The main purpose of filing this issue is for further discussion, currently.

mohrerao’s picture

mohrerao commented
Status: Needs review » Active

Ooh. Sure. Moving it back to Active state.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.