Add our own phpcs.xml that matches Drupal Core. We'll use the one from Drupal Examples project here: https://git.drupalcode.org/project/examples/-/blob/8.x-1.x/phpcs.xml.dist

CommentFileSizeAuthor
#6 3142795-6.patch14.13 KBhussainweb
#4 3142795-4.patch13.94 KBhussainweb
#2 3142795-2.patch13.74 KBhussainweb

Comments

hussainweb created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3142795-2.patch13.74 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3142795-2.patch, failed testing. View results

hussainweb’s picture

hussainweb
Primary language English
commented
Title: Add phpcs.xml.dist » Add phpcs.xml.dist and drupalci.yml
Status: Needs work » Needs review
StatusFileSize
new 3142795-4.patch13.94 KB

The failures are possibly because it is trying to run phpunit tests which we don't yet have.

Status: Needs review » Needs work

The last submitted patch, 4: 3142795-4.patch, failed testing. View results

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3142795-6.patch14.13 KB

Further optimization of the build

Status: Needs review » Needs work

The last submitted patch, 6: 3142795-6.patch, failed testing. View results

hussainweb’s picture

hussainweb
Primary language English
commented

I think the issue is because there are no tests at all and that is hinted in the issue #2990645: "Build Successful" is treated as a test failure. I'll just commit it for now and add tests in a separate issue.

  • hussainweb committed bcaafbe on 8.x-1.x 
    Issue #3142795 by hussainweb: Add phpcs.xml.dist and drupalci.yml
hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.