Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 9.
To read more about this effort by the Drupal Association, please read: Accelerating Drupal 9 module and theme readiness with automated patches
Periodically patches will be added to this issue that remove Drupal 9 deprecations. To stop further patches from being posted simply close this issue(any status besides Active, Needs Review or Needs work) or remove the "ProjectUpdateBotD9" tag from the issue.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open(status of Active, Needs Review or Needs work) and the "RectorAutoPatches" tag is left on this issue, new patches will be posted periodically if new deprecations are needed.
As the Drupal Rector project improves and is able to fix more deprecations the patches posted here will cover more of the deprecations in the module.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecations but don't want new automated patches simply leave this issue open but remove the "RectorAutoPatches" from the issue.
You can use Drupal Rector yourself to make these patches.
If you want to receive automated patches again simply add back the "RectorAutoPatches" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful they can simply close this issue(any status besides Active, Needs Review or Needs work) and no more automated patches will be posted here.
If the issue is reopened then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 9 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the patch in the comment by Project Update Bot
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3140383-7.patch | 1.72 KB | kuhikar |
| #7 | Drupal-Check Success Response.png | 3.05 KB | kuhikar |
| #7 | Git Apply patch successfully.png | 5.74 KB | kuhikar |
| #7 | Drupal-Check Error Response.png | 12.96 KB | kuhikar |
| #7 | Git apply patch error.png | 7.93 KB | kuhikar |
Issue fork entity_events-3140383
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
This patch was created using these packages:
Debug info: Run #1473
Comment #3
project update bot commentedFixing summary
Comment #4
Chris Gillis commented@mattgill Can you please give some guidance on the Project Page about whether this module will get a D9 version? Or is this functionality in D9 core?
Comment #5
joshua.boltz commentedThis simple one-line patch to add D9 support looks good.
It would be great to get this committed to latest dev or stable versions, so that when people pull the project into their codebase via composer, the composer.lock file sets the composer requirements according to the `core_version_requirement` line added with this patch.
For example
Comment #6
joshua.boltz commentedWhen will this be included in a release?
Comment #7
kuhikar commentedHello Team,
I tried to apply patch (entity_events.1.1.rector.patch ), but I am not able to apply patch. Please do check attached image: Git apply patch error.png
Also checked drupal-check, please do check image: Drupal-Check Error Response.png
After applying patch, I am able to successfully apply patch as well as resolved Drupal-check errors. Please do check attached image: Drupal-Check Success Response.png, Git Apply patch successfully.png.
Please review patch: 3140383-7.patch and please release D9 compatible module.
Comment #8
a.dmitriiev commentedThe changes were added to 2.0.x branch. The class for event was used from this issue https://www.drupal.org/project/entity_events/issues/3223423 to have Drupal 9 and 10 smooth upgrade.