Replace usages of AssertLegacyTrait::assertCacheTag, that is deprecated

Adding the "Deprecated assertions" tag to add this into the kanban board https://contribkanban.com/board/Deprecatedassertions

@mondrake Hi

I was trying to apply the patch on latest Drupal 9.1.x then it's give me errors.

curl https://www.drupal.org/files/issues/2020-05-25/3139437-4.patch | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 33911 100 33911 0 0 5013 0 0:00:06 0:00:06 --:--:-- 9843
Checking patch core/modules/block/tests/src/Functional/BlockInstallTest.php...
Checking patch core/modules/block/tests/src/Functional/BlockSystemBrandingTest.php...
Checking patch core/modules/book/tests/src/Functional/BookTest.php...
Checking patch core/modules/comment/tests/src/Functional/CommentAnonymousTest.php...
Checking patch core/modules/config/tests/src/Functional/CacheabilityMetadataConfigOverrideIntegrationTest.php...
Checking patch core/modules/contact/tests/src/Functional/ContactSitewideTest.php...
Checking patch core/modules/content_translation/tests/src/Functional/ContentTranslationWorkflowsTest.php...
Checking patch core/modules/forum/tests/src/Functional/ForumIndexTest.php...
Checking patch core/modules/forum/tests/src/Functional/ForumTest.php...
error: while searching for:

// Test the root forum page title change.
$this->drupalGet('forum');
$this->assertCacheTag('config:taxonomy.vocabulary.' . $this->forum['vid']);
$this->assertTitle(t('Forums | Drupal'));
$vocabulary = Vocabulary::load($this->forum['vid']);
$vocabulary->set('name', 'Discussions');

error: patch failed: core/modules/forum/tests/src/Functional/ForumTest.php:245
error: core/modules/forum/tests/src/Functional/ForumTest.php: patch does not apply
Checking patch core/modules/image/tests/src/Functional/ImageFieldDisplayTest.php...
Checking patch core/modules/node/tests/src/Functional/NodeTypeTest.php...
Checking patch core/modules/page_cache/tests/src/Functional/PageCacheTest.php...
Checking patch core/modules/search/tests/src/Functional/SearchPageCacheTagsTest.php...
Checking patch core/modules/system/tests/src/Functional/Common/EarlyRenderingControllerTest.php...
Checking patch core/modules/system/tests/src/Functional/Entity/EntityListBuilderTest.php...
Checking patch core/modules/system/tests/src/Functional/Menu/LocalTasksTest.php...
Checking patch core/modules/system/tests/src/Functional/Render/DisplayVariantTest.php...
Checking patch core/modules/user/tests/src/Functional/UserLoginTest.php...
Checking patch core/modules/user/tests/src/Functional/UserRegistrationTest.php...
Checking patch core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php...
Checking patch core/tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php...
Hunk #1 succeeded at 201 (offset -3 lines).

So patch need to be re-rolled

Also i create a new patch please review

Sorry #5 was wrong some issue with this patch please review this patch.

#8 is missing the changes to core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php and core/tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php from #4.

Updated patch #8 along with the missed changes as mentioned in #10, please review.

+++ b/core/modules/user/tests/src/Functional/UserRegistrationTest.php
@@ -386,10 +386,10 @@ public function testRegistrationWithUserFields() {
+    $this->assertSession()->responseHeaderContains('X-Drupal-Cache-Tags', 'config:core.entity_form_display.user.user.register');
+    $this->assertSession()->responseHeaderContains('X-Drupal-Cache-Tags', 'config:field.field.user.user.test_user_field');
+   $this->assertSession()->responseHeaderContains('X-Drupal-Cache-Tags', 'config:field.storage.user.test_user_field');
+    $this->assertSession()->responseHeaderContains('X-Drupal-Cache-Tags', 'config:user.settings');

One more tiny issue: the third line here is indented incorrectly.

Otherwise, this is good to go.

@longwave Thanks
RE #13: Fixed
Updated patch #12 along with the missed changes as mentioned in #13, please review.

Pavnish

Thanks for working on this, this looks good now.

The deprecation message suppression for AssertLegacyTrait::assertCacheTag have been removed.
All occurrences of $this->assertCacheTag() have been replaced by $this->assertSession()->responseHeaderContains().
#10 and #13 addressed.
DeprecationListener removed.
All changes look good to me.
The testbot is green.
For me it is RTBC.

@longwave, I guess we are checking this issue on same time. ;)

Committed 2b7d2e1 and pushed to 9.1.x. Thanks!