Replace usages of AssertLegacyTrait::assert(No)Escaped, that is deprecated

Adding the "Deprecated assertions" tag to add this into the kanban board https://contribkanban.com/board/Deprecatedassertions

Patch failed to apply , kindly review a new patch.

Thanks @Hardik_Patel_12!

+++ b/core/modules/block/tests/src/Functional/BlockTest.php
@@ -283,9 +283,9 @@ public function testThemeName() {
-    $this->assertEscaped('<"Cat" & \'Mouse\'>');
+    $this->assertSession()->assertEscaped('<"Cat" & \'Mouse\'>');
...
-    $this->assertEscaped('Demonstrate block regions (<"Cat" & \'Mouse\'>)');
+    $this->assertSession()->assertEscaped('Demonstrate block regions (<"Cat" & \'Mouse\'>)');

+++ b/core/modules/block/tests/src/Functional/BlockXssTest.php
@@ -125,14 +125,14 @@ protected function doViewTest() {
+    $this->assertSession()->assertNoEscaped('<script>alert("view1");</script>:');
+    $this->assertSession()->assertEscaped('<script>alert("view2");</script>:');
...
+    $this->assertSession()->assertEscaped('<script>alert("view1");</script>');
...
+    $this->assertSession()->assertEscaped('<script>alert("view2");</script>: Fish & chips');

+++ b/core/modules/help/tests/src/Functional/HelpTest.php
@@ -141,16 +141,16 @@ protected function verifyHelp($response = 200) {
         foreach ($admin_tasks as $task) {
...
+          $this->assertSession()->assertNoEscaped('&amp;');
+          $this->assertSession()->assertNoEscaped('&lt;');
...
+          $this->assertSession()->assertNoEscaped('<');
...
+        $this->assertSession()->assertNoEscaped('&amp;');
+        $this->assertSession()->assertNoEscaped('&lt;');
...
+        $this->assertSession()->assertNoEscaped('<');

It‘s worthy to do micro-optimizations for changes which similar to the above. See the code blew from \Drupal\FunctionalTests\AssertLegacyTrait::assertSession().

 /**
   * Returns WebAssert object.
   *
   * @param string $name
   *   (optional) Name of the session. Defaults to the active session.
   *
   * @return \Drupal\Tests\WebAssert
   *   A new web-assert option for asserting the presence of elements with.
   */
  abstract public function assertSession($name = NULL);

we should avoid calling $this->assertSession() multiple times in a test. Each call returns a new instance, it's not good. Instead, saving it as a local variable, for example, $assert_session = $this->assertSession(); and using $assert_session for next one(s).

Setting back to NR, it's not worthy to do such micro-optimizations or undecided. See discussions in the parent issue for more.

Rerolled as patch failed to apply

Unassigning as I see others progressing on this.

As with #3139408-14: Replace usages of AssertLegacyTrait::assert(No)Field, that is deprecated, what's up with:

core/tests/Drupal/KernelTests/AssertContentTrait.php defining non-deprecated versions of assert(No)?Escaped()?

That seems highly problematic. Not sure where that's being addressed, but I don't think this is RTBC without reckoning with that.

Sorry,
-Derek

Thanks for clarifying! +1 to RTBC then. I read through the patch and it's just the fix to remove the deprecation from the skip list, the new @legacy deprecation test, and the results of a script. ;)

Thanks,
-Derek

Committed 7628e38 and pushed to 9.1.x. Thanks!