Replace usages of deprecated AssertLegacyTrait::assertElement(Not)Present()

Adding the "Deprecated assertions" tag to add this into the kanban board https://contribkanban.com/board/Deprecatedassertions

Thanks, @mondrake! LGTM. Queued the testing against 9.0.x

Patch failed to apply on 9.0.x.

Needs re-roll. Working on it.

Thanks.

Patch for 9.0.x branch.

diff --git a/core/.cspell.json b/core/.cspell.json

Thanks @sja112! A patch entered a wrong issue

BTW, an interdiff/a raw-interdiff, is always appreciated

@jungle,

Thanks for reporting. My bad didn't check it first before uploading.

Working on it

please review the patch .

+++ b/core/modules/system/tests/src/Functional/Pager/PagerTest.php
--- a/core/tests/Drupal/Tests/Core/Assert/AssertLegacyTraitTest.php
@@ -178,6 +178,30 @@ public function testAssertNoCacheTag() {
+  /**
+   * @covers ::assertElementPresent
+   * @expectedDeprecation AssertLegacyTrait::assertElementPresent() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->elementExists() instead. See https://www.drupal.org/node/3129738
+   */
...
+  /**
+   * @covers ::assertElementNotPresent
...
+   */

They're still supposed to have one-line summaries technically, but I don't care enough about that particular docs standard to NW this given the redundancy with the @covers. :)

Confirmed that 9.1.x had just the one usage, and committed #4. Thanks!

PTBP for a backport that does not un-silence the deprecation.

Uploaded incorrect patch. Correcting mistake here.

@mondrake, thanks for bringing this to my notice. I thought the way we handled depreciations in 9.1.x in similar way we will handle on 8.8.x. That's why I updated the AssertLegacyTrait along with AssertLegacyTraitTest in patch #25.

Patch #26 look good to me. Marking RTBC.

Oops, thought I'd fixed the title before but apparently did not save it. Updating so that the commit message is right at least on the other branches.

Thanks @mondrake for fixing the patch; #26 is indeed what we want for the backports at this point.

Guessing that fail on 9.0.x is random but it's an odd one since it also appears to be a deprecation. Going to wait for the test to finish re-running to be safe.

FWIW I did also just now confirm that there's lots of past instances of:

2x: Passing an escaped locator to the named selector is deprecated as of 1.7 and will be removed in 2.0. Pass the raw value instead.
    2x in EntityQueryAccessTest::testMediaEntityQueryAccess from Drupal\Tests\views\Functional\Entity

...in "xjm's great collection of HEAD failure emails". I'm guessing a random string is mistakenly triggering the error.

I even also reported it before.

Committed #26 to 9.0.x, and cherry-picked to 8.9.x and 8.8.x. I also confirmed all three branches had only the one usage. Thanks!

Meant to mention that I reopened #3041318: [random test failure] Various fails when a random string is used in an xpath selector for the random test failure.