Fix the deprecated code.

CommentFileSizeAuthor
#7 drupal_9_deprecated-3139265-7.patch1.3 KBmglaman
#5 3139265-5.patch1.19 KBrpayanm
#3 Screen Shot 2020-05-23 at 9.12.06 AM.png227.67 KBtsega
deprecated-code.patch824 bytesrpayanm

Comments

rpayanm created an issue. See original summary.

tsega’s picture

tsega commented

@rpayanm, the patch in #1 does not fix the Drupal 9 compatibility issues as reported by the Upgrade Status module. I fear this has been tagged Drupal 9 porting weekend by mistake.

Here is what I mean:

Upgrade Status Report

tsega’s picture

tsega commented
StatusFileSize
new Screen Shot 2020-05-23 at 9.12.06 AM.png227.67 KB
tsega’s picture

tsega commented
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
StatusFileSize
new 3139265-5.patch1.19 KB

Review now please.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Needs work 
+++ b/src/VantivApiHelper.php
@@ -2,6 +2,7 @@
+use Drupal;

@@ -26,7 +27,7 @@ class VantivApiHelper {
-    return REQUEST_TIME + self::getPaymentAuthorizationLifespan($card_type);
+    return Drupal::time()->getRequestTime() + self::getPaymentAuthorizationLifespan($card_type);

We don't import the \Drupal class.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new drupal_9_deprecated-3139265-7.patch1.3 KB

Here's an updated patch.

  • mglaman committed 0a04a3c on 8.x-1.x 
    Issue #3139265 by rpayanm, mglaman, tsega: Drupal 9 deprecated
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed
Issue tags: +Drupal 9 compatibility

Fixed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.