Fix the issues reported by phpcs [#3138916]

Fix below Drupal coding standards.

FILE: css/advanced-cookiebar-advanced.css
--------------------------------------------------------------------------------------
FOUND 84 ERRORS AFFECTING 84 LINES
--------------------------------------------------------------------------------------
   2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
   3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
   4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
   5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
   6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
   7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
   8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
   9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 105 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 107 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 111 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 112 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 113 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 114 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 118 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 125 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 126 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 127 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 128 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 129 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 133 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 134 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 135 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 139 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 140 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 84 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------


FILE: css/advanced-cookiebar-basic.css
-------------------------------------------------------------------------------------
FOUND 23 ERRORS AFFECTING 23 LINES
-------------------------------------------------------------------------------------
  4 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
  8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 25 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 47 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 23 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------


FILE: css/advanced-cookiebar-admin.css
-------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
-------------------------------------------------------------------------------------
  2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  5 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
  6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------


FILE: advanced_cookiebar.module
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 120 ERRORS AND 7 WARNINGS AFFECTING 89 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] Missing file doc comment
   3 | WARNING | [x] Unused use statement
   8 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  12 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
     |         |     hook_foo_BAR_ID_bar() for block templates."
  14 | ERROR   | [x] Doc comment long description must end with a full stop
  16 | ERROR   | [ ] Missing parameter comment
  16 | ERROR   | [ ] Doc comment for parameter $existing does not match actual variable name <undefined>
  17 | ERROR   | [ ] Missing parameter comment
  17 | ERROR   | [ ] Superfluous parameter comment
  18 | ERROR   | [ ] Missing parameter comment
  18 | ERROR   | [ ] Superfluous parameter comment
  19 | ERROR   | [ ] Missing parameter comment
  19 | ERROR   | [ ] Superfluous parameter comment
  20 | ERROR   | [x] Separate the @param and @return sections by a blank line.
  20 | ERROR   | [ ] Description for the @return value is missing
  23 | ERROR   | [x] Opening brace should be on the same line as the declaration
  24 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  24 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  25 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  25 | ERROR   | [x] Short array syntax must be used to define arrays
  26 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
  26 | ERROR   | [x] Short array syntax must be used to define arrays
  27 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  27 | ERROR   | [x] Short array syntax must be used to define arrays
  28 | ERROR   | [x] Array indentation error, expected 14 spaces but found 16
  28 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  29 | ERROR   | [x] Array indentation error, expected 14 spaces but found 16
  29 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  30 | ERROR   | [x] Array indentation error, expected 14 spaces but found 16
  30 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  31 | ERROR   | [x] Array indentation error, expected 14 spaces but found 16
  31 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  32 | ERROR   | [x] Array indentation error, expected 14 spaces but found 16
  32 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  35 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
  35 | ERROR   | [x] Short array syntax must be used to define arrays
  36 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  36 | ERROR   | [x] Short array syntax must be used to define arrays
  37 | ERROR   | [x] Array indentation error, expected 14 spaces but found 16
  37 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  38 | ERROR   | [x] Array indentation error, expected 14 spaces but found 16
  38 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  39 | ERROR   | [x] Array indentation error, expected 14 spaces but found 16
  39 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  40 | ERROR   | [x] Array indentation error, expected 14 spaces but found 16
  40 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  41 | ERROR   | [x] Array indentation error, expected 14 spaces but found 16
  41 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  48 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
     |         |     hook_foo_BAR_ID_bar() for block templates."
  49 | ERROR   | [x] Doc comment short description must end with a full stop
  49 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
  51 | ERROR   | [ ] If there is no return value for a function, there must not be a @return tag.
  51 | ERROR   | [ ] Description for the @return value is missing
  53 | ERROR   | [ ] advanced_cookiebar_install() is an installation hook and must be declared in an install file
  54 | ERROR   | [x] Opening brace should be on the same line as the declaration
  55 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  55 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  56 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  57 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  58 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  59 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  60 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  61 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  62 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  63 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  64 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  65 | ERROR   | [x] Array indentation error, expected 14 spaces but found 16
  66 | ERROR   | [x] Array indentation error, expected 14 spaces but found 16
  66 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  69 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 8
  70 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  72 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  73 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  74 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  74 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
  75 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  76 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  77 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  77 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  81 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
     |         |     hook_foo_BAR_ID_bar() for block templates."
  81 | ERROR   | [x] Doc comment short description must end with a full stop
  85 | ERROR   | [ ] Missing parameter comment
  86 | ERROR   | [x] Separate the @param and @return sections by a blank line.
  86 | ERROR   | [ ] If there is no return value for a function, there must not be a @return tag.
  86 | ERROR   | [ ] Description for the @return value is missing
  89 | ERROR   | [x] Opening brace should be on the same line as the declaration
  90 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  91 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  92 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  93 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  94 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  95 | ERROR   | [x] Expected 1 blank line after function; 2 found
  99 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
     |         |     hook_foo_BAR_ID_bar() for block templates."
  99 | ERROR   | [x] Doc comment short description must end with a full stop
 101 | ERROR   | [x] Doc comment long description must end with a full stop
 103 | ERROR   | [ ] Missing parameter comment
 104 | ERROR   | [x] Separate the @param and @return sections by a blank line.
 104 | ERROR   | [ ] If there is no return value for a function, there must not be a @return tag.
 104 | ERROR   | [ ] Description for the @return value is missing
 106 | ERROR   | [ ] Type hint "array" missing for $variables
 107 | ERROR   | [x] Opening brace should be on the same line as the declaration
 111 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 121 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 123 | ERROR   | [x] Short array syntax must be used to define arrays
 134 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
     |         |     hook_foo_BAR_ID_bar() for block templates."
 134 | ERROR   | [x] Doc comment short description must end with a full stop
 136 | ERROR   | [x] Doc comment long description must end with a full stop
 138 | ERROR   | [ ] Missing parameter comment
 139 | ERROR   | [ ] Missing parameter comment
 140 | ERROR   | [x] Separate the @param and @return sections by a blank line.
 140 | ERROR   | [ ] If there is no return value for a function, there must not be a @return tag.
 140 | ERROR   | [ ] Description for the @return value is missing
 142 | ERROR   | [ ] Type hint "array" missing for $data
 143 | ERROR   | [x] Opening brace should be on the same line as the declaration
 144 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 145 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 147 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 148 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 149 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 153 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
     |         |     hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
     |         |     hook_foo_BAR_ID_bar() for block templates."
 155 | ERROR   | [x] Doc comment long description must end with a full stop
 157 | ERROR   | [ ] Missing parameter comment
 158 | ERROR   | [x] Separate the @param and @return sections by a blank line.
 158 | ERROR   | [ ] Description for the @return value is missing
 161 | ERROR   | [x] Opening brace should be on the same line as the declaration
 162 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 162 | ERROR   | [x] Short array syntax must be used to define arrays
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 94 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------


FILE: advanced_cookiebar.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------


FILE: src/Form/AdvancedCookiebarConfigForm.php
----------------------------------------------------------------------------------------------
FOUND 11 ERRORS AND 1 WARNING AFFECTING 11 LINES
----------------------------------------------------------------------------------------------
   9 | ERROR   | Doc comment is empty
  24 | ERROR   | Missing parameter comment
  25 | ERROR   | Missing parameter comment
  27 | ERROR   | Description for the @return value is missing
  90 | ERROR   | Missing parameter comment
  91 | ERROR   | Missing parameter comment
  93 | ERROR   | If there is no return value for a function, there must not be a @return tag.
  93 | ERROR   | Description for the @return value is missing
 102 | ERROR   | Missing parameter comment
 103 | ERROR   | Missing parameter comment
 105 | ERROR   | Description for the @return value is missing
 107 | WARNING | Possible useless method overriding detected
----------------------------------------------------------------------------------------------


FILE: src/Form/AdvancedCookiebarForm.php
-----------------------------------------------------------------------------------------------
FOUND 14 ERRORS AND 2 WARNINGS AFFECTING 14 LINES
-----------------------------------------------------------------------------------------------
  10 | ERROR   | Doc comment is empty
  14 | ERROR   | Class property $ConfigHelper should use lowerCamel naming without underscores
  14 | ERROR   | Missing member variable doc comment
  16 | ERROR   | Doc comment is empty
  37 | ERROR   | Missing parameter comment
  38 | ERROR   | Missing parameter comment
  40 | ERROR   | Description for the @return value is missing
  73 | WARNING | Only string literals should be passed to t() where possible
  75 | WARNING | Only string literals should be passed to t() where possible
  94 | ERROR   | Missing parameter comment
  95 | ERROR   | Missing parameter comment
  97 | ERROR   | If there is no return value for a function, there must not be a @return tag.
  97 | ERROR   | Description for the @return value is missing
 106 | ERROR   | Missing parameter comment
 107 | ERROR   | Missing parameter comment
 109 | ERROR   | Description for the @return value is missing
-----------------------------------------------------------------------------------------------


FILE: src/Form/AdvancedCookiebarAddConfigForm.php
--------------------------------------------------------------------------------------------------
FOUND 18 ERRORS AFFECTING 15 LINES
--------------------------------------------------------------------------------------------------
  11 | ERROR | Doc comment is empty
  15 | ERROR | Missing member variable doc comment
  17 | ERROR | Class property $ConfigHelper should use lowerCamel naming without underscores
  17 | ERROR | Missing member variable doc comment
  19 | ERROR | Class property $user_selected_key should use lowerCamel naming without underscores
  19 | ERROR | Missing member variable doc comment
  21 | ERROR | Doc comment is empty
  55 | ERROR | Missing parameter comment
  56 | ERROR | Missing parameter comment
  58 | ERROR | Description for the @return value is missing
  70 | ERROR | Function return type is not void, but function is returning void here
 119 | ERROR | Missing parameter comment
 120 | ERROR | Missing parameter comment
 122 | ERROR | If there is no return value for a function, there must not be a @return tag.
 122 | ERROR | Description for the @return value is missing
 141 | ERROR | Missing parameter comment
 142 | ERROR | Missing parameter comment
 144 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------------------------


FILE: src/Form/AdvancedCookiebarRemoveConfigForm.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 14 ERRORS AND 1 WARNING AFFECTING 14 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
  9 | ERROR   | Doc comment is empty
 24 | ERROR   | Missing parameter comment
 25 | ERROR   | Missing parameter comment
 27 | ERROR   | Description for the @return value is missing
 41 | WARNING | Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders
 60 | ERROR   | Missing parameter comment
 61 | ERROR   | Missing parameter comment
 63 | ERROR   | If there is no return value for a function, there must not be a @return tag.
 63 | ERROR   | Description for the @return value is missing
 71 | ERROR   | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
 76 | ERROR   | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
 81 | ERROR   | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
 88 | ERROR   | Missing parameter comment
 89 | ERROR   | Missing parameter comment
 91 | ERROR   | Description for the @return value is missing
--------------------------------------------------------------------------------------------------------------------------------------------


FILE: src/Form/AdvancedCookiebarPageForm.php
-------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 10 LINES
-------------------------------------------------------------------------------------------
  8 | ERROR | Doc comment is empty
 23 | ERROR | Missing parameter comment
 24 | ERROR | Missing parameter comment
 26 | ERROR | Description for the @return value is missing
 77 | ERROR | Missing parameter comment
 78 | ERROR | Missing parameter comment
 80 | ERROR | If there is no return value for a function, there must not be a @return tag.
 80 | ERROR | Description for the @return value is missing
 89 | ERROR | Missing parameter comment
 90 | ERROR | Missing parameter comment
 92 | ERROR | Description for the @return value is missing
-------------------------------------------------------------------------------------------


FILE: src/Form/AdvancedCookiebarSettingsForm.php
------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES
------------------------------------------------------------------------------------------------------
  9 | ERROR   | Doc comment is empty
 24 | ERROR   | Missing parameter comment
 25 | ERROR   | Missing parameter comment
 27 | ERROR   | Description for the @return value is missing
 75 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead
 83 | ERROR   | Missing parameter comment
 84 | ERROR   | Missing parameter comment
 86 | ERROR   | Description for the @return value is missing
------------------------------------------------------------------------------------------------------


FILE: src/Helper/ConfigHelper.php
----------------------------------------------------------------------------------------------------
FOUND 17 ERRORS AFFECTING 12 LINES
----------------------------------------------------------------------------------------------------
   7 | ERROR | Doc comment is empty
  11 | ERROR | Class property $selected_langcode should use lowerCamel naming without underscores
  11 | ERROR | Missing member variable doc comment
  13 | ERROR | Missing member variable doc comment
  15 | ERROR | Class property $default_language should use lowerCamel naming without underscores
  15 | ERROR | Missing member variable doc comment
  17 | ERROR | Class property $default_langcode should use lowerCamel naming without underscores
  17 | ERROR | Missing member variable doc comment
  19 | ERROR | Class property $base_config should use lowerCamel naming without underscores
  19 | ERROR | Missing member variable doc comment
  21 | ERROR | Class property $translatable_config should use lowerCamel naming without underscores
  21 | ERROR | Missing member variable doc comment
  23 | ERROR | Doc comment is empty
  47 | ERROR | Missing parameter comment
  49 | ERROR | Description for the @return value is missing
 110 | ERROR | Doc comment is empty
 133 | ERROR | Doc comment is empty
----------------------------------------------------------------------------------------------------

Comment	File	Size	Author
#3	3138916-3.patch	35.11 KB	ankithashetty

Comments

Comment #1

22 May 2020 at 09:34

Gaurav_drupal created an issue. See original summary.

Comment #2

ankithashetty

Karnataka, India

commented 12 September 2020 at 05:13

Assigned:	gaurav_drupal	» ankithashetty
Issue tags:		+DIACWSep2020

Comment #3

ankithashetty

Karnataka, India

commented 12 September 2020 at 10:20

Assigned:	ankithashetty	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	3138916-3.patch	35.11 KB

Fixed the issues listed above as per Drupal coding standards in the following patch. Kindly review the same.
Please run phpcs --standard=Drupal . to find all the phpcs coding standard errors.

Thank you!

Comment #4

kunal_singh commented 12 September 2020 at 11:04

Status:

Needs review

» Needs work

Great work @ankithashetty

But there are still some issues that needs to be fixed.

FILE: /usr/local/var/www/drupal_modules/advanced_cookiebar/src/Form/AdvancedCookiebarConfigForm.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------------------
 26 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 47 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 47 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 47 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 48 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 64 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 69 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
----------------------------------------------------------------------------------------------------------------------------------


FILE: /usr/local/var/www/drupal_modules/advanced_cookiebar/src/Form/AdvancedCookiebarForm.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------
 27 | WARNING | Unused variable $cookies.
 28 | WARNING | Unused variable $type.
 29 | WARNING | Unused variable $path.
---------------------------------------------------------------------------------------------


FILE: /usr/local/var/www/drupal_modules/advanced_cookiebar/src/Form/AdvancedCookiebarAddConfigForm.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------
  42 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  72 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 101 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 107 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
----------------------------------------------------------------------------------------------------------------------------------


FILE: /usr/local/var/www/drupal_modules/advanced_cookiebar/src/Form/AdvancedCookiebarRemoveConfigForm.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------
 27 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 28 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 45 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
----------------------------------------------------------------------------------------------------------------------------------


FILE: /usr/local/var/www/drupal_modules/advanced_cookiebar/src/Form/AdvancedCookiebarSettingsForm.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
----------------------------------------------------------------------------------------------------------------------------------
 31 | WARNING | Node::load calls should be avoided in classes, use dependency injection instead
 36 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 38 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 39 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 42 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 48 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 50 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 56 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 62 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 67 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
 70 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
    |         | instead
----------------------------------------------------------------------------------------------------------------------------------


FILE: /usr/local/var/www/drupal_modules/advanced_cookiebar/src/Plugin/Block/CookiebarBlock.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 23 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------

Comment #5

kunal_singh commented 12 September 2020 at 11:10

Status:

Needs work

» Reviewed & tested by the community

Please ignore the last comment as phpcs --standard=DrupalPractice . is covered in this issue https://www.drupal.org/project/advanced_cookiebar/issues/3170584

Patch applied succesfully.

Comment #6

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 29 October 2022 at 09:10

Title:	Drupal coding standards	» Fix the issues reported by phpcs
Issue tags:	-DrupalCodingStandard	+Coding standards

Fix the issues reported by phpcs

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Child issues

News items

Our community

Documentation

Drupal code base

Governance of community