Problem/Motivation

Discovered at #2972224: Add .cspell.json to automate spellchecking in Drupal core, and pointed by @xjm in https://www.drupal.org/project/drupal/issues/3122088#comment-13628724

+++ b/core/.cspell.json
@@ -0,0 +1,1288 @@
+      "decription",

Proposed resolution

@xjm: "description".

As title and see the change record https://www.drupal.org/node/3122084 for how to work with cspell.

Remaining tasks

Pick out all applicable words from #2972224: Add .cspell.json to automate spellchecking in Drupal core and fix them.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 Screenshot 2020-05-27 at 2.14.37 PM.png306.5 KBkunalgautam
#2 3138799-2.patch796 bytessja112

Comments

jungle created an issue. See original summary.

sja112’s picture

sja112 commented
Status: Active » Needs review
StatusFileSize
new 3138799-2.patch796 bytes
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

The patch applies cleanly & works as advertised.

On a related note, Grammarly recommends using a hyphen

'#decription' => 'Just client side validation, using the #pattern attribute.',

to

'#decription' => 'Just client-side validation, using the #pattern attribute.',

Most of these spelling issues seem to exists in 8.x as well.

kunalgautam’s picture

kunalgautam commented
StatusFileSize
new Screenshot 2020-05-27 at 2.14.37 PM.png306.5 KB

Patch #2 is working fine.

Good to move to RTBC

ketikagrover’s picture

ketikagrover commented
Assigned: Unassigned » ketikagrover
ketikagrover’s picture

ketikagrover commented
Assigned: ketikagrover » Unassigned
Status: Needs review » Reviewed & tested by the community

looks good to me #patch 2

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

We should also fix: descripcion

Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

Nope, never mind, that's non-English content in a test. Just did not recognize it because it's missing the accent. (Maybe it's Catalan or something and not Spanish? Anyway, it shouldn't be included.)

  • xjm committed 9be077f on 9.1.x 
    Issue #3138799 by sja112, kkalashnikov: Fix "description" relevant typos...

  • xjm committed 0ea5c26 on 9.0.x 
    Issue #3138799 by sja112, kkalashnikov: Fix "description" relevant typos...

  • xjm committed 010fa86 on 8.9.x 
    Issue #3138799 by sja112, kkalashnikov: Fix "description" relevant typos...

  • xjm committed d608789 on 8.8.x 
    Issue #3138799 by sja112, kkalashnikov: Fix "description" relevant typos...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed 
+++ b/core/modules/system/tests/modules/form_test/src/Form/FormTestPatternForm.php
@@ -41,7 +41,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
-      '#decription' => 'Just client side validation, using the #pattern attribute.',
+      '#description' => 'Just client side validation, using the #pattern attribute.',

This is an actual legit bug in the test form fixture.

Given that, I tracked down the test where it is used (emacs core/modules/system/tests/src/Functional/Form/ValidationTest.php) to make sure the test wasn't missing intended test coverage. I confirmed the description is not actually relevant in this case.

@kkalashnikov, please don't attach screenshots of your CLI. "Looks good to me" also normally doesn't receive credit for a review comment. Instead, describe what you reviewed and how. In this case, I'm going to grant you credit because I checked the screenshot and you were trying to help confirm that there were no more results in grep, but next time, you can copy and paste the CLI input and output into an issue <code> tag. Also use grep -ri for a case-insensitive search. Thanks!

Similar advice for @ketikagrover: Describe what you reviewed, and how. Thanks!

@DevJoJodae, I agree about the hyphen for "client-side"; in fact, I'm kind of famous for being the committer that marks patches "Needs work" for that grammar issue. :) However, in this case it's out of scope, as the only goal of the issue is to correct this one kind of typo everywhere so it can be added to core's spellcheck dictionary.

Committed to 9.1.x, and backported to 9.0.x, 8.9.x, and 8.8.x as an allowed fix to test data. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.