Closed (fixed)
Project:
Drupal core
Version:
8.8.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 May 2020 at 05:55 UTC
Updated:
12 Jun 2020 at 00:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jungleComment #3
sja112 commentedComment #4
sja112 commentedComment #5
ankitsingh0188#4 patch looks good to me, I checked with grep -r "Piccasso" * command and there is no other word after applying the patch.
Good to move to RTBC
Comment #6
mohrerao commentedMoving to RTBC as per @ankit's comments.
Comment #11
xjmThanks @ankit.singh for reviewing. No need to attach screenshots of your CLI; in this case, copying and pasting the commands and their output would be sufficient and also more readable.
For future reference, I'd suggest doing
grep -rifor these types of issues to make sure there isn't a lowercase (or all-caps, etc.) variant that was missed from the original list. That'ts what I did myself when committing it just now.Committed to 9.1.x, and cherry-picked to 9.0.x, 8.9.x, and 8.8.x as a patch-eligible cleanup to test data. Thanks!