Problem/Motivation

Discovered at #2972224: Add .cspell.json to automate spellchecking in Drupal core, and pointed by @xjm in https://www.drupal.org/project/drupal/issues/3122088#comment-13628724

+++ b/core/.cspell.json
@@ -0,0 +1,1288 @@
+      "Monocerus",
...
+      "moncerus",
+      "monocerus",

Proposed resolution

@xjm: Should be "Monoceros". A lot of variations of that one...

As title and see the change record https://www.drupal.org/node/3122084 for how to work with cspell.

Remaining tasks

Pick out all applicable words from #2972224: Add .cspell.json to automate spellchecking in Drupal core and fix them.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 Screenshot 2020-05-28 at 11.44.08 PM.png228.77 KBmohrerao
#5 interdiff-3138775-4-5.txt1.55 KBsja112
#5 3138775-5.patch1.99 KBsja112
#4 3138775-4.patch3.54 KBsja112

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Parent issue: » #3122088: [Meta] Remove spelling errors from dictionary.txt and fix them
ramya balasubramanian’s picture

ramya balasubramanian commented
Assigned: Unassigned » ramya balasubramanian
sja112’s picture

sja112 commented
Assigned: ramya balasubramanian » sja112
Status: Active » Needs review
StatusFileSize
new 3138775-4.patch3.54 KB
sja112’s picture

sja112 commented
Assigned: sja112 » Unassigned
StatusFileSize
new 3138775-5.patch1.99 KB
new interdiff-3138775-4-5.txt1.55 KB

Re-uploading patch.

There was some additional change.

ramya balasubramanian’s picture

ramya balasubramanian commented

Hi @sja112,
Please add a comment before assigning this ticket to yourself. Once the ticket is assigned to someone, give atleast one day to work on that. Please don't change the assignee.

sja112’s picture

sja112 commented

@ramya-balasubramanian,

Sorry if you worked on this issue. I was already working on it forgot to assign it to myself.

Thanks for the suggestion I will make note of it and try to not repeat the same.

mohrerao’s picture

mohrerao commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2020-05-28 at 11.44.08 PM.png228.77 KB

Checked for occurrence of Monocerus, moncerus and monocerus and found none.
grep check

  • xjm committed 25595ff on 9.1.x 
    Issue #3138775 by sja112, mohrerao: Fix "Monoceros" relevant typos in...

  • xjm committed 7bacddf on 9.0.x 
    Issue #3138775 by sja112, mohrerao: Fix "Monoceros" relevant typos in...

  • xjm committed 0064be5 on 8.9.x 
    Issue #3138775 by sja112, mohrerao: Fix "Monoceros" relevant typos in...

  • xjm committed 2dc0c9d on 8.8.x 
    Issue #3138775 by sja112, mohrerao: Fix "Monoceros" relevant typos in...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.1.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks everyone!

@mohrerao, thanks for checking with grep; that's helpful and specific review information -- definitely valuable to me as a committer. In the future, I'd suggest just copying and pasting the CLI text rather than creating a screenshot. (Easier to read that way, and it'll avoid a kneejerk response of uncrediting a screenshot of CLI output, since we get those all the time for things where it isn't helpful like applying a patch.)

Committed to 9.1.x, and cherry-picked to 9.0.x, 8.9.x, and 8.8.x as a patch-eligible fix to test data. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.