[D8] OptGroup Taxonomy Select

Swetha_Bapanah Thanks for your contribution.

Can you please check this code at line 39 of modules/contrib/optgroup_taxonomy_select/src/Plugin/Field/FieldWidget/OptgroupTermSelectWidget.php

$result[$parent][$item->tid] = $item->name;

It looks like the $parent variable is undefined. You might want to initialize it.

@Swetha_Bapanah,

Thanks for your contribution.

Use dependency injection instead of calling directly \Drupal::entityTypeManager() in the class file.

Use "entity_type.manager" service and inject this service into OptionsWidgetBase class.

Thanks for the update.
Some variables are useless in the construct section

public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, array $third_party_settings, EntityTypeManagerInterface $entity_type_manager) {
    parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings, $third_party_settings);
    $this->entityTypeManager = $entity_type_manager;
} 

Instead, Please add the below code

/**
   * Constructor.
   *
   * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
   *   The config service.   
   */
  public function __construct(EntityTypeManagerInterface $entity_type_manager) {
    $this->entityTypeManager = $entity_type_manager;
  }

and same issue on create function also, please update with the below,

public static function create(ContainerInterface $container) {
    return new static(     
      $container->get('entity_type.manager')
    );
  }

and remove unnecessary classes from the use section.

Once committed the code into branch, Please check for any coding standard issues by Pareview url.

Don't create a new tag for each update. Please use the same branch and push the code into same branch.
Reviewer will refer the code from the current default branch. In your case the branch is 8.x-1.x. Once it is stable, then create new tag.

@Swetha_Bapanah
I'm not able to add value. Can you please check this and i have attached screenshot for your reference.

The following code is correct.

public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, array $third_party_settings, EntityTypeManagerInterface $entity_type_manager) {
    parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings, $third_party_settings);
    $this->entityTypeManager = $entity_type_manager;
}

It's calling the parent constructor method, which is expecting those values.

@kiamlaluno, You are correct.

@Swetha_Bapanah

You don't need to implement the code that i have mentioned above.

Hi @Swetha_Bapanah,

Kindly check below errors.

2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ -----------------------------------------------------------------------
Line src/Plugin/Field/FieldWidget/OptgroupTermSelectWidget.php
------ -----------------------------------------------------------------------
87 Access to an undefined property
Drupal\optgroup_taxonomy_select\Plugin\Field\FieldWidget\OptgroupTerm
SelectWidget::$multiple.
87 Access to an undefined property
Drupal\optgroup_taxonomy_select\Plugin\Field\FieldWidget\OptgroupTerm
SelectWidget::$options.
96 Access to an undefined property
Drupal\optgroup_taxonomy_select\Plugin\Field\FieldWidget\OptgroupTerm
SelectWidget::$multiple.
96 Method
Drupal\optgroup_taxonomy_select\Plugin\Field\FieldWidget\OptgroupTerm
SelectWidget::getEmptyLabel() should return string|null but return
statement is missing.
98 Access to an undefined property
Drupal\optgroup_taxonomy_select\Plugin\Field\FieldWidget\OptgroupTerm
SelectWidget::$required.
106 Access to an undefined property
Drupal\optgroup_taxonomy_select\Plugin\Field\FieldWidget\OptgroupTerm
SelectWidget::$required.
109 Access to an undefined property
Drupal\optgroup_taxonomy_select\Plugin\Field\FieldWidget\OptgroupTerm
SelectWidget::$has_value.
------ -----------------------------------------------------------------------

[ERROR] Found 7 errors

Hi @Swetha_Bapanah,

In my vocabulary, there are around 300 terms. Please see screenshot.

I am closing this application due to lack of replies.