system_batch_page() should call drupal_exit() after drupal_access_denied()

@mikeytown2, thanks for filing this.

Applying IS template, tagging "Needs tests" and "Bug Smash Initiative".

Thanks for the issue and patch. I've tested as follows:

1. Installed Drupal 7 dev
2. Went to /batch
3. Noted the error in the logs (same as in issue summary)
4. Applied the patch
5. Went to /batch
6. Noted the error in the logs (just shows 403s as it should)

Moving back to "needs work" for tests.

Hi All,

thanks for the good work.

Adding a test for the patch provided by mikeytown2.
I also added the interdiff for the same.

this need a review.

thanks

Thanks @awangsetyawan for the test. I have tweaked it a little bit to remove the need of the new method (assertNoLogMessage()), so we can keep the code cleaner.

Adding test-only patch and regular patch to see if testbot will be happy. If yes, I think this can be set as RTBC, as the patch is trivial and it is confirmed also by manual testing.

As I have mentioned in #6, I am setting this as RTBC, because patch was unchanged and confirmed that is is working before. Tests are passing / failing as expected too.

@poker10 Thanks for the updated patch. Please create an interdiff when making changes:

https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa...

Since you updated the patch, you can't mark this RTBC so moving back to Needs review.

Thanks @Kristen Pol for pointing this out. It seems like I made an unintentional mistake here - I did not mean to RTBC my own patch. Reuploading the patch from #6 again with an interdiff, which was missing here.

Thanks @poker10 :)

There are several other places in core where we call drupal_exit() after drupal_access_denied() for example:

modules/user/user.pages.inc:271:      drupal_access_denied();
modules/user/user.pages.inc-272-      drupal_exit();
--
modules/contact/contact.pages.inc:23:    drupal_access_denied();
modules/contact/contact.pages.inc-24-    drupal_exit();
--
modules/contact/contact.pages.inc:191:    drupal_access_denied();
modules/contact/contact.pages.inc-192-    drupal_exit();

Patch looks good, thanks!

What’s RTBM? Curious:)

RTBM is Ready To Be Merged :) so approved by one maintainer for another to commit.

It's mentioned in #3093258: [policy, no patch] Proposed Drupal 7 contributor / maintainer workflow which never really got beyond a draft, but we've been following it pretty much for a while in D7.

Oh! Very cool. I wasn’t familiar. Thanks:)

Thanks everyone who contributed!