The current version has the codesnippetgeshi submodule available, but in the current status it is not usable, it depends from some ckeditor plugins and some changes on one of them, so we need:

  • List every plugin necessary to make it work(with links to where download).
  • Create a patch with the necessary changes on plugin and provide a download of it with the patch already applyed.
  • Document this.
CommentFileSizeAuthor
#2 3137968-2.patch1.35 KByukare

Comments

yukare created an issue. See original summary.

yukare’s picture

yukare commented
StatusFileSize
new 3137968-2.patch1.35 KB

I put a link to readme file in the module description page and did some changes to readme file. Lets see if need some other change.

  • yukare committed 6dd00a2 on 8.x-2.x 
    Fix for #3137968. Just a small change to readme.
yukare’s picture

yukare commented
Status: Active » Fixed

It does not need much changes, just make the readme more clear.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

wolf_22’s picture

wolf_22 commented

Saying this is "fixed" is like believing you still have transportation when your car is broken but your legs still work. Technically, it's true...

...but we all know better.

At a minimum, this issue should be an ongoing issue... This "sub-module" should be inherent functionality to this entire module and encapsulated to the geshifilter module folder. Nobody should need to manually create folders at root level and place specific JavaScript files into it to make this work. What has to happen to fix this?

Until it's fixed, these manual steps are going to keep causing problems for people and force maintainers to choose paths of more resistance, which isn't good for anyone.

yukare’s picture

yukare commented
Status: Closed (fixed) » Needs work

We need some libraries from ckeditor, and i am not sure if its best pratice add then to geshifilter. Drupal.org says to not host code from other sources unless we need to change it.

I will see if I can download and install then with composer, this will make it more simple.

Geshifilter too need an external library which is downloaded and installed by hand, but composer can do it now.

marcoka’s picture

marcoka commented

Yes it does

codesnippetgeshi/plugin.js
codesnippet/plugin.js?t=qgi886
libraries/ajax/plugin.js?t=qgi886
libraries/xml/plugin.js?t=qgi886

Will test the readme now, shoudl work.