Closed (fixed)
Project:
Dropsolid Rocketship Core
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 May 2020 at 15:44 UTC
Updated:
21 Jun 2023 at 06:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
nielsaers commentedCreated a quick patch that removes the logic for rendering the content in the templates. It might need some looking into why the empty check was not enough.
Comment #3
nielsaers commentedComment #4
nielsaers commentedCreated another patch that actually brings back the functionality of conditional regions but only renders the output once. So the downside is that the entire contents get rendered in the twig file.
As with the related issue, there is no real fix yet that takes into account all the edge cases. (e.g. bigpipe,...)
Resources: https://www.lullabot.com/articles/level-your-twiggery#checking-field-is-...
Comment #5
nielsaers commentedComment #7
rembrandx commentedPatch 4 applied and adding to new release (alpha 6), thanks @Niels! Sorry it took a while to get in.
Comment #9
nginex commentedBackported existing patch to 8.x-1.x, will be available in new release