Problem/Motivation

Notice: Undefined index: data in webform_validation_manage_rule_validate() (line 309 of webform_validation/webform_validation.admin.inc).

When using 'Unique' on a select field I run into this, noticed it doesn't define a 'custom_data' key and when you save the validation rule the error above shows up.

Proposed resolution

The data key (custom_data) is optional, check it's existence before using it.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3136050-4-empty-check-data.patch823 bytesmrinalini9
#2 3136050-2-empty-check-data.patch827 bytesjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new 3136050-2-empty-check-data.patch827 bytes

Did an empty() check because it's equivalent to what it was doing without the notice due to implicit isset() check in the empty() function.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Needs work

Patch does not apply.

mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new 3136050-4-empty-check-data.patch823 bytes

Rerolled patch #2, please review.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.