Problem/Motivation

As title

Proposed resolution

Remove redundant assertion messages at the same time.

Example:

-  $this->assertTrue(isset($behaviors['access_denied']['label']), 'The access denied plugin has a label');
+ $this->assertArrayHasKey('label', $behaviors['access_denied'], 'The access denied plugin has a label');

Comments

VitaliyB98 created an issue. See original summary.

vitaliyb98’s picture

Status: Active » Needs review
StatusFileSize
new1.7 KB
jeroent’s picture

Status: Needs review » Needs work
jeroent’s picture

Issue tags: +Novice, +Needs reroll
Swapnil_Kotwal’s picture

StatusFileSize
new14.43 KB
Swapnil_Kotwal’s picture

Status: Needs work » Needs review
jeroent’s picture

Assigned: vitaliyb98 » Unassigned
rajeevchoudhary’s picture

Assigned: Unassigned » rajeevchoudhary
jeroent’s picture

Status: Needs review » Needs work

Patch failed to apply.

ankithashetty’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new1.74 KB

Re-rolled the patch. Kindly review...

Thanks!

jeroent’s picture

Status: Needs review » Reviewed & tested by the community

LGTM.

matroskeen’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

matroskeen’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.