Fix 'The "Symfony\Component\BrowserKit\Response::getStatus()" method is deprecated since Symfony 4.3, use getStatusCode() instead.'

Thanks for the patch.

1) I don't see anything wrong with the patch. I read the issue summary in #3060996: Fix The "Symfony\Component\BrowserKit\Response::getStatus()" method is deprecated since Symfony 4.3, use getStatusCode() instead. and reviewed the commit https://git.drupalcode.org/project/drupal/commit/74e4b5d which added:

      // This deprecation comes from behat/mink-browserkit-driver when updating
      // symfony/browser-kit to 4.3+.
      'The "Symfony\Component\BrowserKit\Response::getStatus()" method is deprecated since Symfony 4.3, use getStatusCode() instead.',

I compared this code with the code being removed in the patch and it's identical.

2) Patch applied cleanly to 9.0 and 9.1.

[mac:kristen:drupal-9.0.x-dev]$ patch -p1 < 3135308.patch
patching file core/tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php
[mac:kristen:drupal-9.0.x-dev]$ cd91
[mac:kristen:drupal-9.1.x-dev]$ patch -p1 < 3135308.patch
patching file core/tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php

3) The issue summary says:

Since then behat/mink-browserkit-driver has released a new version that should remove the deprecation warning.

The patch from #3060996: Fix The "Symfony\Component\BrowserKit\Response::getStatus()" method is deprecated since Symfony 4.3, use getStatusCode() instead. was committed 11 August 2019 at 17:25.

Versions of behat/mink-browserkit-driver are:

1.3.4 - 2020-03-11 09:49 UTC
1.3.3 - 2018-05-02 09:25 UTC

I'm unclear where this is fixed. I see the same getStatus() and getStatusCode() calls in both versions. I assume I don't understand something obvious here.

[mac:kristen:MinkBrowserKitDriver]$ git checkout v1.3.3
HEAD is now at 1b9a7ce... Merge pull request #127 from pamil/patch-1
[mac:kristen:MinkBrowserKitDriver]$ grep -r "getStatus()" .
./src/BrowserKitDriver.php:        return $this->getResponse()->getStatus();
[mac:kristen:MinkBrowserKitDriver]$ git checkout v1.3.4
Previous HEAD position was 1b9a7ce... Merge pull request #127 from pamil/patch-1
HEAD is now at e3b9084... Update the changelog
[mac:kristen:MinkBrowserKitDriver]$ grep -r "getStatus()" .
./src/BrowserKitDriver.php:            return $response->getStatus();

[mac:kristen:MinkBrowserKitDriver]$ git checkout v1.3.3
Previous HEAD position was e3b9084... Update the changelog
HEAD is now at 1b9a7ce... Merge pull request #127 from pamil/patch-1
[mac:kristen:MinkBrowserKitDriver]$ grep -r "getStatusCode()" .
./tests/Custom/BaseUrlTest.php:        $this->assertEquals(200, $session->getStatusCode());
./src/BrowserKitDriver.php:    public function getStatusCode()
[mac:kristen:MinkBrowserKitDriver]$ git checkout v1.3.4
Previous HEAD position was 1b9a7ce... Merge pull request #127 from pamil/patch-1
HEAD is now at e3b9084... Update the changelog
[mac:kristen:MinkBrowserKitDriver]$ grep -r "getStatusCode()" .
./tests/Custom/BaseUrlTest.php:        $this->assertEquals(200, $session->getStatusCode());
./src/BrowserKitDriver.php:    public function getStatusCode()
./src/BrowserKitDriver.php:        return $response->getStatusCode();

@narendra.rajwar27 If you aren't able to get to finish updating an issue within a few hours, it's best to unassign it so others might work on it. Thanks.

I have updated the patch to fix

'The "Symfony\Component\BrowserKit\Response::getStatus()" method is deprecated since Symfony 4.3, use getStatusCode() instead.'

This deprecation is not added in the release. I am working on Drupal 9.1.x latest codebase.

#3060996: Fix The "Symfony\Component\BrowserKit\Response::getStatus()" method is deprecated since Symfony 4.3, use getStatusCode() instead. 
Automatically closed - issue fixed for 2 weeks with no activity.

Please review.

Committed and pushed ef61d27660 to 9.1.x and 492710b7ab to 9.0.x. Thanks!

Backported to 9.0.x as this is a test-only fix.

@longwave Thanks for the thoughtful explanation! And to @sja112 for the update! And to @alexpott for the commit! :)