Review of the 8.x-1.2 branch (commit 201bf8a):
Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The INSTALLATION section is missing.
The CONFIGURATION section is missing.
The contact_indexing.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.
FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
1 | WARNING | Line exceeds 80 characters; contains 153 characters
2 | WARNING | Line exceeds 80 characters; contains 112 characters
11 | WARNING | Line exceeds 80 characters; contains 91 characters
--------------------------------------------------------------------------
FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/contact_indexing.module
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
42 | ERROR | [ ] Parameter tags must be grouped together in a doc
| | comment
45 | ERROR | [ ] Type hint "array" missing for $form
47 | ERROR | [x] Concat operator must be surrounded by a single space
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
Time: 415ms; Memory: 4Mb
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Screenshot 2020-05-13 at 6.51.57 PM.png | 209.93 KB | Rkumar |
| #3 | 3135300-2.patch | 3.1 KB | abhijeet.kumar2107 |
Comments
Comment #2
abhijeet.kumar2107 commentedComment #3
abhijeet.kumar2107 commentedPatch attached please reivew
Comment #4
abhijeet.kumar2107 commentedComment #5
abhijeet.kumar2107 commentedComment #6
Rkumar commentedPatch looks good to me. Moving to RTBC
Comment #7
deepak tomar commentedupdated in 8.x-1.0-beta1 release.
Comment #8
deepak tomar commentedupdated in 8.x-1.0-beta1 release
Comment #9
avpaderno