Active
Project:
Drupal core
Version:
main
Component:
phpunit
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 May 2020 at 06:27 UTC
Updated:
3 May 2020 at 06:27 UTC
Jump to comment: Most recent
From @longwave in #3123253-28: Remove usage of AssertLegacyTrait::pass() from base test classes:
+++ b/core/tests/Drupal/FunctionalTests/Installer/ConfigAfterInstallerTestBase.php
@@ -32,13 +32,7 @@ protected function assertInstalledConfig(array $skipped_config) {
+ $this->assertConfigDiff($result, $config_name, $skipped_config);
I checked what this method does and it doesn't actually perform assertions, rather it just throws an exception on failure. This means we have to use the $this->addToAssertionCount(1); workaround at the top of the method as there are now no assertions here. Worth opening a new issue to make it more PHPUnit-y?
Comments