Follow-up to #3131186: Replace assertions involving calls to drupalGetHeader() with session-based assertions, where possible

CommentFileSizeAuthor
#21 interdiff.3132887.18-21.txt2.16 KBlongwave
#21 3132887-21.patch9.35 KBlongwave
#18 3132887-17.patch9.35 KBmondrake
#18 interdiff_15-17.txt1013 bytesmondrake
#15 3132887-15.patch9.34 KBkishor_kolekar
#14 interdiff_8_12.txt1.21 KBanmolgoyal74
#13 3132887-12.patch9.4 KBanmolgoyal74
#8 interdiff_5-8.txt2.01 KBmondrake
#8 3132887-8.patch9.3 KBmondrake
#5 interdiff.3132887.4-5.txt852 byteslongwave
#5 3132887-5.patch9.32 KBlongwave
#4 3132887-4.patch8.49 KBmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +Deprecated assertions
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Postponed » Active

Parent is in, unblocking.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
Issue tags: +Needs tests, +Needs change record
StatusFileSize
new 3132887-4.patch8.49 KB

Not much usage left. Needs a change record and a deprecation test.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue tags: -Needs tests
StatusFileSize
new 3132887-5.patch9.32 KB
new interdiff.3132887.4-5.txt852 bytes

Added deprecation test.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Deprecate FunctionalTestBase:: drupalGetHeader » Deprecate BrowserTestBase::drupalGetHeader()

Fix title.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue tags: -Needs change record

Added CR: https://www.drupal.org/node/3168383

mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new 3132887-8.patch9.3 KB
new interdiff_5-8.txt2.01 KB

Reflected CR # in the patch.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

tanubansal’s picture

tanubansal commented

Tested #5,#8, changes are visible
RTBC

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
kishor_kolekar’s picture

kishor_kolekar commented
Assigned: Unassigned » kishor_kolekar
anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs work » Needs review
StatusFileSize
new 3132887-12.patch9.4 KB

Re-rolled

anmolgoyal74’s picture

anmolgoyal74 commented
StatusFileSize
new interdiff_8_12.txt1.21 KB

Adding interdiff.

kishor_kolekar’s picture

kishor_kolekar commented
Assigned: kishor_kolekar » Unassigned
Issue tags: -Needs reroll
StatusFileSize
new 3132887-15.patch9.34 KB

The last submitted patch, 13: 3132887-12.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 15: 3132887-15.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_15-17.txt1013 bytes
new 3132887-17.patch9.35 KB

Fixed deprecation test.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

I did work on this patch but I am unsure who else would review it, so marking RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Looks good overall but the deprecation now needs to be made for 9.2.0...

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 3132887-21.patch9.35 KB
new interdiff.3132887.18-21.txt2.16 KB

Rerolled for 9.2.0.

  • catch committed f5c6bf0 on 9.2.x 
    Issue #3132887 by mondrake, longwave, anmolgoyal74, kishor_kolekar:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed f5c6bf0 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tr’s picture

tr commented

Change record was never published and is outdated. I updated it and published it.