Sort bundle list when creating an entity

Here's what it looks like without the patch.

And after the patch.

Hi, I have tested this patch with Drupal 9.0 as well as 8.9.x version since i was facing same order issue in 8.9.x version of Drupal.
patch in #2 is working fine in both versions. sharing screenshots for reference in before and after patch manner.

@jyotimishra123 Thanks but why did you test it when it had already been tested?

Hi @Kristen Pol, the issue was mentioning for 9.0 version and i was facing this in 8.9 too, so i found this patch and applied and shared my result too. i did not specifically test this issue, was working something and used this patch so i thought i should share the result too..
I m new to this contribution so did not know that only one can share the testing response..Thanks!!

@jyotimishra123 Gotcha. Welcome to Drupal contribution! Hope you're able to help out during the D9 porting weekend.

Thanks @jyotimishra123! Usually we want to make sure we don't duplicate others' work because it adds noise, it's not fair in terms of issue credit, and it's better to work on things someone else hasn't already addressed. :)

That said, your manual testing results do help document why you consider the issue RTBC, which is good. We value it when someone who reviews a patch documents what they tested and why they think the issue is ready. So for that reason I'm keeping your credit on the issue as well as @Kristen Pol for the reviews.

A few more things we should address here:

1. I think we need an automated test for this.

2. +++ b/core/modules/node/src/Controller/NodeController.php
   @@ -104,6 +104,10 @@ public function addPage() {
   +    // Sort the entities using the entity class's sort() method.
   +    // See \Drupal\Core\Config\Entity\ConfigEntityBase::sort().
   +    uasort($content, [$this->entityTypeManager()->getDefinition('node_type')->getClass(), 'sort']);
   

   I'm confused here. If we're using the Entity API to sort it, why are we also doing a uasort() on the result?
    

3. I'm also wondering if this should be addressed at the level of the list builder, rather than in the controllers. The fact that we have to repeat something on the node list builder makes me think the sorting should be done earlier.

Hi @xjm,
Hoping you fine in this pandemic situation due to coronavirus!!
Agreed with your point and also got your point.
will take care these things in future, Thanks a alot.

I came across this issue while doing bugsmash triage.
I am not able to reproduce this issue.

It seems that this issue is already been fixed.

I can see that sort method is added on load() https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co... for ConfigEntityListBuilder.php

NodeTypeListBuilder essentially calls `ConfigEntityListBuilder` only.

There is another issue #2265487: ConfigEntity based lists with items containing non-ascii characters are not sorted correctly which we worked on to provide sorting for non-ascii characters.
I think we should close this since above issue is more generic, also this isn't reproducible anymore.

Re-rolled patch from #2 for D11.4.6