[D8] Commerce Product Tax Conditions

Thank you for applying! I added the Git instructions for non-maintainer users. Reviewers will check the project and post comments to list what should be changed.

Hello,
Fix following issue

FILE: /app/web/modules/contrib/commerce_product_tax_exempt/tests/src/Functional/TaxTypeConditionsFormTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
51 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

Hi, please fix mentioned issue

../vendor/bin/drupal-check modules/contrib/commerce_product_tax_exempt/ -d

6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ----------------------------------------------------------------------------------------------------------------
Line src/Plugin/Commerce/Condition/CustomerRoleCondition.php
------ ----------------------------------------------------------------------------------------------------------------
Class Drupal\commerce_order\Plugin\Commerce\Condition\OrderCustomerRole not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
19 Class Drupal\commerce_order\Plugin\Commerce\Condition\OrderCustomerRole not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
------ ----------------------------------------------------------------------------------------------------------------

------ ---------------------------------------------------------------------------------------------------
Line src/Resolver/ConditionTaxRateResolver.php
------ ---------------------------------------------------------------------------------------------------
Class Drupal\commerce_product_tax\Resolver\TaxRateResolver not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
16 Class Drupal\commerce_product_tax\Resolver\TaxRateResolver not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
------ ---------------------------------------------------------------------------------------------------

------ -------------------------------------------------------------------------------------------------------
Line tests/src/Functional/TaxTypeConditionsFormTest.php
------ -------------------------------------------------------------------------------------------------------
Class Drupal\Tests\commerce\Functional\CommerceBrowserTestBase not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
14 Class Drupal\Tests\commerce\Functional\CommerceBrowserTestBase not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
------ -------------------------------------------------------------------------------------------------------

[ERROR] Found 6 errors

Hi, please fix mentioned issue

../vendor/bin/drupal-check modules/contrib/commerce_product_tax_exempt/ -d

6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ----------------------------------------------------------------------------------------------------------------
Line src/Plugin/Commerce/Condition/CustomerRoleCondition.php
------ ----------------------------------------------------------------------------------------------------------------
Class Drupal\commerce_order\Plugin\Commerce\Condition\OrderCustomerRole not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
19 Class Drupal\commerce_order\Plugin\Commerce\Condition\OrderCustomerRole not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
------ ----------------------------------------------------------------------------------------------------------------

------ ---------------------------------------------------------------------------------------------------
Line src/Resolver/ConditionTaxRateResolver.php
------ ---------------------------------------------------------------------------------------------------
Class Drupal\commerce_product_tax\Resolver\TaxRateResolver not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
16 Class Drupal\commerce_product_tax\Resolver\TaxRateResolver not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
------ ---------------------------------------------------------------------------------------------------

------ -------------------------------------------------------------------------------------------------------
Line tests/src/Functional/TaxTypeConditionsFormTest.php
------ -------------------------------------------------------------------------------------------------------
Class Drupal\Tests\commerce\Functional\CommerceBrowserTestBase not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
14 Class Drupal\Tests\commerce\Functional\CommerceBrowserTestBase not found and could not be autoloaded.
💡 Learn more at https://phpstan.org/user-guide/autoloading
------ -------------------------------------------------------------------------------------------------------

[ERROR] Found 6 errors

HI @ozin,

I used ../vendor/bin/drupal-check -d modules/contrib/commerce_product_tax_exempt/

Hi ozin,

Thanks for your contribution!

See below url, hope this help you to install drupal check.

https://github.com/mglaman/drupal-check/wiki/Drupal-9-Readiness

Since this module declares its dependency from the commerce_product_tax module, I take that drupal-check was run before loading all the module dependencies.
It could be the module should declare more dependencies than it does, but given the false positives drupal-check gives in the reports I see in these applications, I would suggest to verify the instructions to use it are correctly followed, or use another tool to check a module declares all the dependencies correctly.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.