Replace assertions involving calls to is_string() with assertIsString()/assertIsNotString()

Please review patch.

Used the regex mentioned in #4 to get a list of all occurances, there were 33. Then applied the patch and ran the grep again, and 19 still found. The 19 are asserts and not subject to change here.As jungle says above, 'found no more assertions to replace.

Also reviewed the patch and found no problems, also all assertion messages removed.

Committed/pushed to 9.1.x and 9.0.x, thanks!

Needs a backport for 8.9.x

To backport this (and similar others), we would need to do #3126787: [D8 only] Add forwards-compatibility shim for assertInternalType() replacements in phpunit 6&7 first, that is part of #3110543: [meta] Support PHPUnit 9 in Drupal 9.

Blocker is in.

#10 is passing on D8.9 now.

+++ b/core/tests/Drupal/KernelTests/Core/TypedData/TypedDataTest.php
@@ -73,7 +73,7 @@ public function testGetAndSet() {
-    $this->assertTrue(is_string($typed_data->getString()), 'Boolean value was converted to string');

@@ -91,7 +91,7 @@ public function testGetAndSet() {
-    $this->assertTrue(is_string($typed_data->getString()), 'String value was converted to string');

@@ -107,7 +107,7 @@ public function testGetAndSet() {
-    $this->assertTrue(is_string($typed_data->getString()), 'Integer value was converted to string');

@@ -124,7 +124,7 @@ public function testGetAndSet() {
-    $this->assertTrue(is_string($typed_data->getString()), 'Float value was converted to string');

@@ -229,7 +229,7 @@ public function testGetAndSet() {
-    $this->assertTrue(is_string($typed_data->getString()), 'DurationIso8601 value was converted to string');

@@ -253,7 +253,7 @@ public function testGetAndSet() {
-    $this->assertTrue(is_string($typed_data->getString()), 'Time span value was converted to string');

These removed assertion messages are adding information about what's going on in the test: That these are conversions of various specific data types to a string. You can still mostly understand this from the surrounding inline comments, but if we do more work removing assertion messages from this file, we're going to need to add some comments.

Since this is a backport and it's mostly OK, I'm going to go ahead and commit the 8.9.x patch. Just remember to be careful about not losing information from the test when we get rid of static assertion messages. Thanks

not pushed?

Good catch. Apparently my push was rejected earlier with a bunch of access denied errors from GitLab... reommitted now. Thanks!

#18 sometimes there is quite a delay between a push and the appearance of the 'committed' comment on the issue itself. I've seen that myself on projects I maintain. But can's find a reason for that.