Replace assertions involving calls to is_object() with assertIsObject()/assertIsObject()

Updating IS and mentioning to remove assertion messages

@mero.S, I did assign to myself. 🤦 If you want to work on one issue, better to assign yourself first. I will still submit mine, interdiff and comments coming next.

Wrong interdiff submitted in #8, sorry.

@mero.S, no worries, anyway, thanks for working on this!

Review of #6

1. The replacement is incomplete, see the interdiff in #9

2. +++ b/core/modules/content_translation/tests/src/Functional/ContentTranslationUITestBase.php
   @@ -369,7 +369,7 @@ protected function doTestTranslationDeletion() {
   -    if ($this->assertIsObject($entity)) {
   +    if (is_object($entity)) {
   

   Instead of replacing it, I did remove the assertion in if which makes more sense to me.

Note for reviewer(s): the assertion message below inside the foreach loop was kept on purpose, as no consent reached on such case yet.

+++ b/core/tests/Drupal/KernelTests/Core/Database/FetchTest.php
@@ -39,7 +39,7 @@ public function testQueryFetchObject() {
     foreach ($result as $record) {
       $records[] = $record;
-      $this->assertTrue(is_object($record), 'Record is an object.');
+      $this->assertIsObject($record);
       $this->assertIdentical($record->name, 'John', '25 year old is John.');

Regex used: assert.+is_object

Note for reviewer(s): the assertion message below inside the foreach loop was kept on purpose, as no consent reached on such case yet.

Wrong comment in #11, sorry again, in fact, 3 foreach loops in total were touched, one assertion message in one of them was kept on purpose only.

+++ b/core/tests/Drupal/KernelTests/Core/Cache/GenericCacheBackendUnitTestBase.php
@@ -274,7 +274,7 @@ public function testValueTypeIsKept() {
     foreach ($variables as $cid => $value) {
       $object = $backend->get($cid);
-      $this->assert(is_object($object), sprintf("Backend returned an object for cache id %s.", $cid));
+      $this->assertIsObject($object, sprintf("Backend returned an object for cache id %s.", $cid));

+++ b/core/tests/Drupal/KernelTests/Core/Database/FetchTest.php
@@ -24,7 +24,7 @@ public function testQueryFetchDefault() {
     foreach ($result as $record) {
       $records[] = $record;
-      $this->assertTrue(is_object($record), 'Record is an object.');
+      $this->assertIsObject($record);

@@ -39,7 +39,7 @@ public function testQueryFetchObject() {
     foreach ($result as $record) {
       $records[] = $record;
-      $this->assertTrue(is_object($record), 'Record is an object.');
+      $this->assertIsObject($record);

+++ b/core/modules/content_translation/tests/src/Functional/ContentTranslationUITestBase.php
@@ -369,7 +369,7 @@ protected function doTestTranslationDeletion() {
-    if ($this->assertTrue(is_object($entity), 'Entity found')) {
+    if (is_object($entity)) {

Fixing testing failure in #7. Doubt the original code inside if never gets executed, as it's always false. -- assertTrue returns void/null?

+++ b/core/modules/content_translation/tests/src/Functional/ContentTranslationUITestBase.php
@@ -369,11 +369,10 @@ protected function doTestTranslationDeletion() {
+    $this->assertTrue(is_object($entity), 'Entity found');
+    $translations = $entity->getTranslationLanguages();
+    $this->assertCount(2, $translations, 'Translation successfully deleted.');
+    $this->assertArrayNotHasKey($langcode, $translations, 'Translation successfully deleted.');

Code snippet from #3129074. Thank you @mondrake! Then I'd postpone this to let #3129074 land first.

Rerolled from #16

Thanks all!

Rejected file: core/tests/Drupal/KernelTests/Core/Cache/GenericCacheBackendUnitTestBase.php

(rejected hunks)
@@ -144,7 +144,7 @@ public function testSetGet() {
     $this->assertFalse($backend->get('test2'), "Backend does not contain data for cache id test2.");
     $backend->set('test2', ['value' => 3], REQUEST_TIME + 3);
     $cached = $backend->get('test2');
-    $this->assert(is_object($cached), "Backend returned an object for cache id test2.");
+    $this->assertIsObject($cached);
     $this->assertSame(['value' => 3], $cached->data);
     $this->assertTrue($cached->valid, 'Item is marked as valid.');
     $this->assertTrue($cached->created >= REQUEST_TIME && $cached->created <= round(microtime(TRUE), 3), 'Created time is correct.');
@@ -231,16 +231,16 @@ public function testDelete() {
 
     $this->assertFalse($backend->get('test1'), "Backend does not contain data for cache id test1.");
     $backend->set('test1', 7);
-    $this->assert(is_object($backend->get('test1')), "Backend returned an object for cache id test1.");
+    $this->assertIsObject($backend->get('test1'));
 
     $this->assertFalse($backend->get('test2'), "Backend does not contain data for cache id test2.");
     $backend->set('test2', 3);
-    $this->assert(is_object($backend->get('test2')), "Backend returned an object for cache id %cid.");
+    $this->assertIsObject($backend->get('test2'));
 
     $backend->delete('test1');
     $this->assertFalse($backend->get('test1'), "Backend does not contain data for cache id test1 after deletion.");
 
-    $this->assert(is_object($backend->get('test2')), "Backend still has an object for cache id test2.");
+    $this->assertIsObject($backend->get('test2'));
 
     $backend->delete('test2');
     $this->assertFalse($backend->get('test2'), "Backend does not contain data for cache id test2 after deletion.");