Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
28 Apr 2020 at 08:23 UTC
Updated:
3 Jun 2020 at 11:29 UTC
Jump to comment: Most recent
Comments
Comment #2
ankush_03Hi rolki,
Thanks for your contribution !
Please fix below issue reported by pareview :
Git errors:
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch (commit 353563c):
README.md or README.txt is missing, see the guidelines for in-project documentation.
Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
FILE: ...review_temp/src/Plugin/Field/FieldFormatter/MediaSingleFormatter.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
31 | ERROR | [x] Array closing indentation error, expected 4 spaces but
| | found 6
105 | ERROR | [x] Expected 1 blank line after function; 2 found
108 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
Time: 552ms; Memory: 4Mb
Comment #3
ankush_03Comment #4
avpaderno(It's the first time a user adds the PAReview: single application approval tag to his own application. With such honesty, I would give to the user the vetted role without requiring another application.)
Comment #5
avpadernoComment #6
rolki commentedHi!
Thanks for the quick response)
Actually, errors were fixed when I created this ticket, and the README file also was created :) Strange. And I don't use anymore master branch (for now it's 8.x-1.x)
Comment #7
rolki commentedkiamlaluno, sorry for this, this is my first request to get "security advisory coverage" :)
Comment #8
avpaderno@rolki You don't need to be sorry. Quite the opposite, you correctly set the tag, and I think I will consider this when approving this application. :)
Comment #9
rolki commentedComment #10
shaktikHi rolki,
Thanks for your contribution!
Please fix below issue.
Comment #11
shaktikComment #12
rolki commentedHi shaktik,
Thanks, fixed.
Comment #13
rolki commentedComment #14
rolki commentedHi guys, any updates here?
Comment #15
rohitrajputsahab commented@rolki
Everything is fine from my side.
Comment #16
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #17
rolki commentedHi,
Thank you very much, I will look at the articles that you shared. Whenever possible, I will take an active part in the review process :)