Overview

Provide field formatter plugin for the media entity.

Base module features:

* Select view mode
* Select delta for the multiple media

Project page

https://www.drupal.org/project/single_media

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/single_media.git

Pareview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-single_media.git

Comments

rolki created an issue. See original summary.

ankush_03’s picture

Hi rolki,

Thanks for your contribution !

Please fix below issue reported by pareview :

Git errors:
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch (commit 353563c):
README.md or README.txt is missing, see the guidelines for in-project documentation.
Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

FILE: ...review_temp/src/Plugin/Field/FieldFormatter/MediaSingleFormatter.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
31 | ERROR | [x] Array closing indentation error, expected 4 spaces but
| | found 6
105 | ERROR | [x] Expected 1 blank line after function; 2 found
108 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 552ms; Memory: 4Mb

ankush_03’s picture

Status: Needs review » Needs work
avpaderno’s picture

(It's the first time a user adds the PAReview: single application approval tag to his own application. With such honesty, I would give to the user the vetted role without requiring another application.)

avpaderno’s picture

rolki’s picture

Hi!
Thanks for the quick response)
Actually, errors were fixed when I created this ticket, and the README file also was created :) Strange. And I don't use anymore master branch (for now it's 8.x-1.x)

rolki’s picture

kiamlaluno, sorry for this, this is my first request to get "security advisory coverage" :)

avpaderno’s picture

@rolki You don't need to be sorry. Quite the opposite, you correctly set the tag, and I think I will consider this when approving this application. :)

rolki’s picture

Status: Needs work » Needs review
shaktik’s picture

Hi rolki,

Thanks for your contribution!

Please fix below issue.

drupal-check -ad web/modules/contrib/single_media/
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------
  Line   src/Plugin/Field/FieldFormatter/MediaSingleFormatter.php
 ------ -------------------------------------------------------------------------------
  83     Call to deprecated method strpos() of class Drupal\Component\Utility\Unicode:
         in drupal:8.6.0 and is removed from drupal:9.0.0. Use
         mb_strpos() instead.
 ------ -------------------------------------------------------------------------------


 [ERROR] Found 1 error
shaktik’s picture

Status: Needs review » Needs work
rolki’s picture

Hi shaktik,
Thanks, fixed.

rolki’s picture

Status: Needs work » Needs review
rolki’s picture

Hi guys, any updates here?

rohitrajputsahab’s picture

@rolki

Everything is fine from my side.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

rolki’s picture

Hi,
Thank you very much, I will look at the articles that you shared. Whenever possible, I will take an active part in the review process :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.