Most of Drupal use snake case for the variable naming convention.

The PHP code in configuration_update_hook.php.twig should also try to adhere to that as well.

CommentFileSizeAuthor
#8 3131228-use-snake-case-on-configuration_update_hook-8.patch1.15 KBcodebymikey
#7 3131228-use-snake-case-on-configuration_update_hook-7.patch1011 bytescodebymikey
#5 Captura de tela de 2020-04-28 08-55-14.png215.64 KBilgnerfagundes
#4 3131228-use-snake-case-on-configuration_update_hook-4.patch1021 bytescodebymikey
#3 Screenshot from 2020-04-27 10-42-02.png55.51 KBpaulocs
#2 3131228-use-snake-case-on-configuration_update_hook.patch1.18 KBcodebymikey

Issue fork update_helper-3131228

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

codebymikey created an issue. See original summary.

codebymikey’s picture

codebymikey commented
Status: Active » Needs review
StatusFileSize
new 3131228-use-snake-case-on-configuration_update_hook.patch1.18 KB
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2020-04-27 10-42-02.png55.51 KB

RTBC. Good job @codebymikey.

codebymikey’s picture

codebymikey commented
StatusFileSize
new 3131228-use-snake-case-on-configuration_update_hook-4.patch1021 bytes

Change the name from $updateHelper to $updater to be more accurate.

ilgnerfagundes’s picture

ilgnerfagundes commented
StatusFileSize
new Captura de tela de 2020-04-28 08-55-14.png215.64 KB

The patch continues to apply correctly.

codebymikey opened merge request !1

codebymikey’s picture

codebymikey commented
Version: 8.x-1.x-dev » 2.x-dev
StatusFileSize
new 3131228-use-snake-case-on-configuration_update_hook-7.patch1011 bytes

Rerolled for 2.x.

codebymikey’s picture

codebymikey commented
StatusFileSize
new 3131228-use-snake-case-on-configuration_update_hook-8.patch1.15 KB

Fixed issue with multiple line breaks showing up, as well as ensuring that the newly created .install file meets Drupal's coding standards.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

FWIW Drupal allows camelCase or snake_case see https://www.drupal.org/project/coding_standards/issues/2648050

However there's no reason to not do this change.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

I've removed commit credit for @paulocs and @ilgnerfagundes because both screenshots are unnecessary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

  • alexpott committed e2a9570 on 2.x authored by codebymikey 
    Issue #3131228 by codebymikey: Use snake case in generated hook function

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.