Problem/Motivation

As title

Proposed resolution

For example:

-    $this->assertTrue(is_dir('temporary://' . $test_directory));
+    $this->assertDirectoryExists('temporary://' . $test_directory);

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3131090-2.patch8.08 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3131090-2.patch8.08 KB
msuthars’s picture

msuthars
Location Pune
CreditAttribution: msuthars as a volunteer and at QED42 for Drupal India Association commented
Assigned: Unassigned » msuthars
msuthars’s picture

msuthars
Location Pune
CreditAttribution: msuthars as a volunteer and at QED42 for Drupal India Association commented
Assigned: msuthars » Unassigned
Status: Needs review » Reviewed & tested by the community

@longwave Patch looks fine for me. I have reviewed and tested it and it working as expected.

  • catch committed 610d4b6 on 9.1.x 
    Issue #3131090 by longwave: Replace assertions involving calls to is_dir...

  • catch committed 58a7082 on 9.0.x 
    Issue #3131090 by longwave: Replace assertions involving calls to is_dir...

  • catch committed 8e265e8 on 8.9.x 
    Issue #3131090 by longwave: Replace assertions involving calls to is_dir...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.1.x and cherry-picked back to 8.9.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.