Closed (fixed)
Project:
Nodeaccess
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
25 Apr 2020 at 02:56 UTC
Updated:
3 Nov 2021 at 17:59 UTC
Jump to comment: Most recent
#3119558: Add core_version_requirement to info.yml file
#3070372: Remove deprecate code
#3169639: D9: Individual node permissions don't work
These bugs are important, but they are NOT specific to Drupal 9 readiness.
#3185156: Permission to individual Users throws error on grants tab of nodes
#3061378: Table name typo?
#3236472: Class Drupal\Component\Utility\Html referenced with incorrect case in src/Form/ConfigForm.php
#3236475: Refactor nodeaccess.install
#3236465: Improve issue 3145629 -- coding standards further
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
alisonComment #3
alisonComment #4
elusivemind commentedWork updating the Grants form in terms of compliant SQL queries has started. After hammering, a lot of work on the grants of roles seems to be working but individual permissions still needs work. Most errors have been eliminated on the GrantsForm, there is much work to be done. Current work pushed to the dev branch.
Comment #5
elusivemind commentedComment #6
alisonGreat summary, belated thanks!
Comment #7
alisonComment #8
alisonComment #9
ARRC-Drupal-Chick commentedAre the Drupal 9 compatibility issues still being worked on?
This is the only module keeping me from upgrading to Drupal 9.
Thank you.
Comment #10
devdesagar commentedHello Team,
We are using nodeaccess in one of the sites in drupal which is to be ported to drupal 9.
Can anyone please release a stable version.
Thanks and Regards,
Sagar Devde
Comment #11
hip commentedMe too after a Drupal 9 stable version upgrade.
Comment #12
hockey2112 commentedAny news on a D9 stable release?
Comment #13
alisonHi all! Short answer is: No news, and I welcome offers to discuss co-maintaining ;-)
Slightly longer answer is: I realize that it's getting more and more time sensitive to have a D9 release, and I hope it'll be soon, but -- not making excuses, just explaining -- I've got house selling and moving stuff taking up my life the last six months, and I think it'll be over soon, but I'm no longer naive enough to make "promises".
Not an ideal situation, but, it is what it is.
Happy Spring/Fall!
Comment #14
devdesagar commentedHello alisonjo315,
I would like to be co-maintainer of this module.
Would provide me co-maintainership of this module.
Thanks and Regards,
Sagar Devde
Comment #15
ushasharma84 commentedAny Update regarding availablity of Node Access in Drupal 9?
Comment #16
austin_brian commentedThis module provides critical functionality for a site I maintain. As we prepare for upgrading the site from Drupal 8 to 9, we look forward to any updates on a D9-ready version of nodeaccess. Thank you.
Maybe considering Sagar Devde's offer to co-maintain the module would help resume progress.
Comment #17
inbalj commentedI'm encountering the same concern as #16. We are also in the final preparations for upgrading our site to D9 and this module is crucial for our site as well.
I would appreciate an estimation when D9 stable release will be available.
Comment #18
Coops_+1 on getting a release for this
Comment #19
jungleOne of my Drupal 9 instances relies on this module heavily, I would like to be a co-maintainer of this module too.
Comment #20
jungleAdding another one
Comment #21
jungleOne more
Comment #22
alisonThanks for the contributions and feedback, everybody! I added Sagar Devde a little over a week ago.
@jungle I'll message you.
Comment #23
jungle@alisonjo315, replied on slack, thanks!
Comment #24
alisonComment #25
alisonHi everybody,
Status update:
FWIW, I happily give issue credit for careful/thoughtful reviews 💙💙
Thank you for your contributions and patience :) Pretty soon, we'll all be able to use this clunky old module on another major version of Drupal -- that's the dream, right?
Comment #26
alisonComment #27
bakerlee commentedWould someone please post the status for release of nodeaccess in Drupal 9? We need to plan and would appreciate this information. Thanks!
Comment #28
mirakolous commentedI am using the upgrade_status module for Drupal 9 readiness. After adding the patch, it was compatible for D9. Works for me!
Comment #29
jungleMade two commits, one for #3070372: Remove deprecate code, the other for #3169639: D9: Individual node permissions don't work.
Commented to both #3185156: Permission to individual Users throws error on grants tab of nodes and #3061378: Table name typo? which are not blockers anymore, I think.
@alisonjo315, is it time to make an alpha release for Drupal 9?
Comment #30
jungleAdding #3236465: Improve issue 3145629 -- coding standards further to Nice to have.
Comment #31
jungleAdd two committed to Nice to have.
Comment #32
zoraxI am using the upgrade_status module for Drupal 9. After adding the patch , I have 6 errors :
CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Nodeaccess 8.x-1.0
Scanned on mar 21 sep 2021.
5 errors found. 1 warning found. Avoid some manual work by using drupal-rector
for fixing issues automatically or Upgrade Rector to generate patches.
Help port this project at #3130778: Drupal 9 readiness of Nodeaccess
modules/contrib/nodeaccess/src/Form/GrantsForm.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 44 │ Call to deprecated function db_query(). Deprecated in │
│ │ │ drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get │
│ │ │ a database connection injected into your service from the │
│ │ │ container and call query() on it. For example, │
│ │ │ $injected_database->query($query, $args, $options); │
│ │ │ │
│ Fix now │ 69 │ Call to deprecated function db_query(). Deprecated in │
│ │ │ drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get │
│ │ │ a database connection injected into your service from the │
│ │ │ container and call query() on it. For example, │
│ │ │ $injected_database->query($query, $args, $options); │
│ │ │ │
│ Fix now │ 99 │ Call to deprecated function db_query(). Deprecated in │
│ │ │ drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get │
│ │ │ a database connection injected into your service from the │
│ │ │ container and call query() on it. For example, │
│ │ │ $injected_database->query($query, $args, $options); │
│ │ │ │
│ Fix now │ 339 │ Call to deprecated function db_insert(). Deprecated in │
│ │ │ drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get │
│ │ │ a database connection injected into your service from the │
│ │ │ container and call insert() on it. For example, │
│ │ │ $injected_database->insert($table, $options); │
│ │ │ │
│ Fix with │ 351 │ Call to deprecated function drupal_set_message(). Deprecated │
│ rector │ │ in drupal:8.5.0 and is removed from drupal:9.0.0. Use │
│ │ │ Drupal\Core\Messenger\MessengerInterface::addMessage() │
│ │ │ instead. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘
modules/contrib/nodeaccess/nodeaccess.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Vérifie │ 0 │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ r │ │ module is compatible with Drupal 9. See │
│ manuelle │ │ https://drupal.org/node/3070687. │
│ ment │ │ │
Does it exist another patch ?
Comment #33
jungleRe #32, I think you were not using the dev version of the module, 8.x-1.0 used instead.
See https://www.drupal.org/project/nodeaccess/releases/8.x-1.x-dev, or run
composer require 'drupal/nodeaccess:1.x-dev@dev'before applying the patch.Comment #34
zoraxThanks Jungle !I wasn't using the dev version.!It works.
Comment #35
timodwhit commentedWhile the DI is a nice to have, is it a dependency for a solid release for 9.x? It seems like we would be able to cut a beta or full release with the previous changes without the need for the DI Changes?
Or if they are a hard requirement, should we move them under that?
Comment #36
dasginganinja@jungle Can we please get a 9.x alpha release? I'm would prefer not to switch to a -dev release. There's just too many horror stories with those! 😂
Comment #37
jungleSorry, @dasginganinja, I only have the commit permission. But I had left @alisonjo315 a message to do it around a month ago. She replied me that she did put it into her to-do list.
Comment #39
alisonHi all! I did get to look two weeks ago, but didn't finish looking.
I expect to publish a release later today 🤞🤞
Comment #50
alisonRelease is published; also adding credit for everyone who contributed to the release (i.e. the full list seen on the release page) (might not work but I'm going to try).
https://www.drupal.org/project/nodeaccess/releases/8.x-1.1
Comment #55
alison(four more -- the last four, I think)