There is an issue in ProxySubscriber event subscriber with building a redirect URL. The $relative_path is not properly encoded when the URL is being built and this can cause issues when there are special characters included in the relative path (ex. <img src="/sites/default/files/styles/small_xs/public/2019-03/Header-F%2BB_microkontrast_03_web.jpg" alt="Han® F+B" typeof="foaf:Image" title="Han® F+B">). The solution is to URL encode the $relative_path before building the redirect URL.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | stage_file_proxy-relative-path-url-encoding-3130512-9.patch | 607 bytes | cleverhoods |
| #5 | stage_file_proxy-relative-path-url-encoding-3130512-5.patch | 565 bytes | falco010 |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
uros.ceh commentedComment #3
geek-merlinCan you extend the existing tests to cover this case too?
Comment #4
eelkeblokComment #5
falco010#2 did not apply to 1.1 anymore
Hereby a reroll of #2, which can be applied to 1.2
Comment #6
smustgrave commentedComment #7
smustgrave commentedCould this be tested on 2.1.x too?
Comment #8
smustgrave commentedSince there has been no response going to close for now. If still experiencing this issue please reopen
Comment #9
cleverhoods commentedRerolling previous patch for 3.1.x
Comment #10
cleverhoods commentedComment #11
smustgrave commentedPatches should be in MRs this was never merged so nothing to port
Comment #14
stephen-cox commentedPatch #9 fixed this issue for me. Without it images with special characters were redirecting to themselves and so weren't loading.
I've also created a MR which contains the patch with a small whitespace fix.
Comment #15
smustgrave commentedI'm fine with this change.
Thanks!