FILE: ...es/contrib/menu_multilingual/tests/src/Functional/MenuMultilingualTest.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------------
455 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
468 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
480 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
509 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
522 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
534 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
556 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead

CommentFileSizeAuthor
#8 interdiff-3130169-5-8.txt2.82 KBmrinalini9
#8 3130169-8.patch2.78 KBmrinalini9
#5 interdiff_2-5.txt1.3 KBsuresh prabhu parkala
#5 3130169-5.patch3.26 KBsuresh prabhu parkala
#2 3130169-2.patch2.84 KBmo_farhaz

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz commented
Assigned: mo_farhaz » Unassigned
Status: Active » Needs review
StatusFileSize
new 3130169-2.patch2.84 KB

please review.

kapilv’s picture

kapilv commented
Issue tags: +warning
matsbla’s picture

matsbla commented
Status: Needs review » Needs work 
Drupal\Tests\menu_multilingual\Functional\MenuMultilingualTest::testViewsMenuItemTranslated
Error: Call to undefined method Drupal\Tests\menu_multilingual\Functional\MenuMultilingualTest::t()
suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 3130169-5.patch3.26 KB
new interdiff_2-5.txt1.3 KB

Please review!

matsbla’s picture

matsbla commented
Status: Needs review » Needs work

Hmm.
Look at this issue
#3133726: [meta] Remove usage of t() in tests not testing translation
I think maybe t() should not be used in these tests at all!

mrinalini9’s picture

mrinalini9 commented
Assigned: Unassigned » mrinalini9
mrinalini9’s picture

mrinalini9 commented
Assigned: mrinalini9 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3130169-8.patch2.78 KB
new interdiff-3130169-5-8.txt2.82 KB

Updated patch as per the changes mentioned in #6.

  • matsbla committed 844c0e6 on 8.x-1.x authored by mrinalini9 
    Issue #3130169 by mrinalini9, Suresh Prabhu Parkala, mo_farhaz: t()...
matsbla’s picture

matsbla commented
Title: t() calls should be avoided in classes » t() calls should be avoided in tests
Status: Needs review » Fixed

Great, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.