Add Bootstrap Grid support to Layout Builder module. currently, work for both Bootstrap 3 and Bootstrap 4.

Project link

https://www.drupal.org/project/bootstrap_layout_builder

Git instructions

git clone --branch 1.x https://git.drupalcode.org/project/bootstrap_layout_builder.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-bootstrap_layo...

Comments

mahmoud-zayed created an issue. See original summary.

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Status: Active » Needs work

Hi @mahmoud,

Thanks for your contribution !

Please fix git errors :
Git errors:
It appears you are working in the "1.x" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

mahmoud-zayed’s picture

mahmoud-zayed commented
Status: Needs work » Needs review

Hi @Ankush

Drupal.org doesn't require anymore those type of tags/branches, now that Semantic Versioning releases are supported.
Please check the following references which are recently updated:
Release naming conventions: https://www.drupal.org/node/1015226
Semver: https://semver.org/

Kind Regards,
Mahmoud Zayed

shaktik’s picture

shaktik
he/him
Primary language Hindi
Location New Delhi
commented
Issue summary: View changes

Update remote URLs from SSH to HTTPS due to getting Permission denied for other user.

git clone --branch 1.x git@git.drupal.org:project/bootstrap_layout_builder.git
Cloning into 'bootstrap_layout_builder'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
mahmoud-zayed’s picture

mahmoud-zayed commented

Hi shaktik,

This error means that, you need to configure the public key at your Drupal account, not related to the module.

Regards

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

@mahmoud-zayed No, that error is caused from the fact that only maintainers of a project can use git clone --branch 1.x git@git.drupal.org:project/bootstrap_layout_builder.git to clone a project. The other users can only use git clone --branch 1.x https://git.drupalcode.org/project/bootstrap_layout_builder.git.

mahmoud-zayed’s picture

mahmoud-zayed commented

Got it @kiamlaluno Thanks for the explanation.

mahmoud-zayed’s picture

mahmoud-zayed commented

Hi Team,

Would you please review this and let me know.

Thanks,
Mahmoud

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

mahmoud-zayed’s picture

mahmoud-zayed commented

Thank you @Kiamlaluuno and thank you team 🙂

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Fixed » Needs work

@kiamlaluno - can you double check you granted permission properly?

mahmoud-zayed’s picture

mahmoud-zayed commented
Status: Needs work » Needs review

Thanks for your response @greggles, @kiamlaluno The issue that I am still don't have the permission to "Opt into security advisory coverage" for the module, would you check and advise?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

I apologize: mahmoud-zayed didn't have the vetted role assigned. Now he has it.

mahmoud-zayed’s picture

mahmoud-zayed commented

@kiamlaluno Thank you :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.