Problem/Motivation

Database drivers should be able to override the default implementations of Drupal\Core\Database\Query\PagerSelectExtender, Drupal\Core\Database\Query\TableSortExtender and Drupal\search\SearchQuery.

Proposed resolution

Allow database drivers to override default implementations of Drupal\Core\Database\Query\PagerSelectExtender, Drupal\Core\Database\Query\TableSortExtender and Drupal\search\SearchQuery.

Remaining tasks

None

User interface changes

None

API changes

Database drivers can now override query extenders.

Data model changes

None

Release notes snippet

TBD

CommentFileSizeAuthor
#7 3129563-7.patch13.27 KBdaffie
#4 3129563-4.patch13.27 KBdaffie
#4 interdiff-3129563-2-4.txt978 bytesdaffie
#2 3129563-2.patch12.81 KBdaffie

Comments

daffie created an issue. See original summary.

daffie’s picture

daffie commented
Status: Active » Needs review
StatusFileSize
new 3129563-2.patch12.81 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3129563-2.patch, failed testing. View results

daffie’s picture

daffie commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-3129563-2-4.txt978 bytes
new 3129563-4.patch13.27 KB
daffie’s picture

daffie commented
Issue tags: +Bug Smash Initiative

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

daffie’s picture

daffie commented
StatusFileSize
new 3129563-7.patch13.27 KB

Fixed the cspell failure. s/DataProvider/Data provider

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. @daffie out of curiosity what is the use case for this?

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +Needs change record

We probably need a change record here.

daffie’s picture

daffie commented
Issue summary: View changes
Issue tags: -Needs change record

Added a CR and updated the IS.

  • catch committed 738ac00 on 9.2.x 
    Issue #3129563 by daffie, mondrake: The database query extenders does...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Looks very solid and makes sense for parity with the rest of the API. Committed/pushed to 9.2.x, thanks!

daffie’s picture

daffie commented

Marked the CR as published.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.