The "growing underline" focus state on the text input and button elements does not work in Firefox

CommentFileSizeAuthor
#7 3129267-7.patch961 bytesmherchel
#2 primary_search_fix_firefox-3129267-2.patch376 bytesvinitk
olivero-ff-focus.png191.97 KBmherchel
#2 firefix-search-focus.png52.64 KBvinitk
#5 primary_search_fix_firefox-3129267-3.patch376 bytesvinitk

Comments

mherchel created an issue. See original summary.

vinitk’s picture

vinitk commented
StatusFileSize
new primary_search_fix_firefox-3129267-2.patch376 bytes
new firefix-search-focus.png52.64 KB

Here, form CSS margin is causing the issue. I tried to fix with CSS specific to the header search wide component.

vinitk’s picture

vinitk commented

olivero search focus

vinitk’s picture

vinitk commented
Status: Active » Needs review
vinitk’s picture

vinitk commented
StatusFileSize
new primary_search_fix_firefox-3129267-3.patch376 bytes
kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Needs review » Needs work

@vinitk you have to read these articles: https://www.drupal.org/docs/8/themes/olivero/how-to-contribute-to-olivero and https://www.drupal.org/docs/8/themes/olivero/development-setup

dist folder contains compiled css

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 3129267-7.patch961 bytes

Attaching and committing updated patch. Thanks!

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.