Update PHP platform and version requirements for Guardr Project's composer.json referencing Drupal Project's composer.json.

Examples for review:

Comments

shrop created an issue. See original summary.

shrop’s picture

shrop commented

Conversation in Drupal Slack related to this issue:

https://drupal.slack.com/archives/C1BF0CUAV/p1587155731031700

shrop 4:35 PM
@joestewart Do you think there is anything wrong with removing the following https://github.com/guardrdistro/guardr-project/blob/8.x/composer.json#L37 (edit)
and moving to this:
https://github.com/drupal-composer/drupal-project/blob/8.x/composer.json...
? ran into an issue trying to add Rector to Guardr Project locally because it didn’t like being locked to that PHP version with composer require

composer.json:19
"php": ">=7.0.8",
drupal-composer/drupal-project | Added by GitHub

joestewart 4:42 PM
Is the first one the 5.6 line here? https://github.com/guardrdistro/guardr-project/blob/8.x/composer.json#L13
composer.json:13
"php": ">=5.6",
guardrdistro/guardr-project | Added by GitHub

shrop’s picture

shrop commented
Issue summary: View changes
shrop’s picture

shrop commented
Status: Active » Needs review

Created PR for review: https://github.com/guardrdistro/guardr-project/pull/28

shrop credited joestewart.

shrop’s picture

shrop commented
Status: Needs review » Fixed

Tests pass so merged https://github.com/guardrdistro/guardr-project/pull/28

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.