[D8] Views Json Source

Thank you for applying! I added the Git instructions for non-maintainer users and the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.

If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

README.txt file contains some issues related to coding standard.

FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
-------------------------------------------------------------------------------
15 | WARNING | Line exceeds 80 characters; contains 82 characters
48 | WARNING | Line exceeds 80 characters; contains 88 characters
50 | WARNING | Line exceeds 80 characters; contains 84 characters
63 | WARNING | Line exceeds 80 characters; contains 81 characters
68 | WARNING | Line exceeds 80 characters; contains 81 characters
89 | WARNING | Line exceeds 80 characters; contains 83 characters
94 | WARNING | Line exceeds 80 characters; contains 83 characters
103 | WARNING | Line exceeds 80 characters; contains 83 characters
108 | WARNING | Line exceeds 80 characters; contains 83 characters
120 | WARNING | Line exceeds 80 characters; contains 91 characters

Apply the below patch file for #3.

Thank you for your contribution!

Review of the 8.x-1.x branch (commit c0ff5c3): looks good to me.

The task of reviewers is pointing out what needs to be change, not providing patches.

Reviewed 8.x-1.x and looks good to me.

General

• Consider consistent spelling of JSON: I see some instances of Json and JSON throughout.
• Consider adding tests.

views_json_source.info.yml

• (+) Dependencies declared as an object/hash, convention is as an array. Instead of
  

  dependencies:
    views: 'drupal:views'
  

  It should be

  dependencies:
    - 'drupal:views'
  

• (+) core_version_requirement: ^8 line not needed if the Drupal only supports Drupal 8. This line is for Drupal >=8.7 and 9. Is there any reason why this module couldn't be compatible with Drupal 9?

src/Form/ViewsJsonSourceSettingsForm.php

• (+) For the cache_ttl form element, one should use '#type' => 'number' for a number field instead of textfield with overridden #attributes.
• For the cache_ttl form element, consider adding '#min' => 0 as I believe a negative TTL would not make sense in this context.
• For the cache_ttl form element, consider using an integer for the #size parameter.

config/schema/views_json_source.schema.yml

• Prefer single quotes over double quotes for strings

Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.