Replace usages of deprecated AssertLegacyTrait::assert()

I have visually scanned this patch

All the conversions look good.... I found one minor flaw.

--- a/core/modules/migrate/tests/src/Kernel/MigrateTestBase.php
+++ b/core/modules/migrate/tests/src/Kernel/MigrateTestBase.php
@@ -205,7 +205,7 @@ public function display($message, $type = 'status') {
       $this->migrateMessages[$type][] = $message;
     }
     else {
-      $this->assert($type == 'status', $message, 'migrate');
+      $this->assertEquals('status', $type);
     }
   }

While I don't find the migrate message very helpful. There is no need to drop it.

In terms of the standard review ..

A) I agree with all the reasoning behind the need for this issue.
B) Looking at the test artefacts there are no additional errors.

$view_link = $this->xpath('//div[@class="messages"]//a[contains(@href, :href)]', [':href' => 'contact/']);
-    $this->assert(isset($view_link), 'The message area contains a link to a contact form.');
+    $this->assertTrue(isset($view_link), 'The message area contains a link to a contact form.');

$view_link is FALSE if the query is malformed or errors occurred,

I think the isset() in combination with assertTrue() is perfectly readable justifiable code.

+++ b/core/tests/Drupal/FunctionalTests/Bootstrap/UncaughtExceptionTest.php
@@ -285,7 +285,7 @@ public function testLoggerException() {
     $expected_line = 59;
     $expected_entry = "Failed to log error: Exception: Deforestation in Drupal\\error_service_test\\MonkeysInTheControlRoom->handle() (line ${expected_line} of ${expected_path})";
-    $this->assert(strpos($errors[0], $expected_entry) !== FALSE, 'Original error logged to the PHP error log when an exception is thrown by a logger');
+    $this->assertTrue(strpos($errors[0], $expected_entry) !== FALSE, 'Original error logged to the PHP error log when an exception is thrown by a logger');
 
     // The exception is expected. Do not interpret it as a test failure. Not

This can be an assertStringCointainsString.

Also we should deprecate the assert method, and add a deprecation test. Better postpone on #3114617: Properly deprecate methods in Drupal\FunctionalTests\AssertLegacyTrait and Drupal\KernelTests\AssertLegacyTrait, while still keeping deprecations silenced?

Patch re-rolled. Includes some new changes. Change mentioned in #6 not required anymore.

Updated patch. Change in WebAssert.php file was not required.

Found a duplicate issue marked as child to this issues already has been resolved in #9

Thanks @sja112!

1. +++ b/core/modules/views/tests/src/Functional/Handler/HandlerTest.php
   @@ -230,18 +230,13 @@ public function testHandlerWeights() {
   +    $this->assertTrue($expected == $handler->value, $message);
   

   use assertEquals()?

2. +++ b/core/tests/Drupal/KernelTests/Core/Cache/GenericCacheBackendUnitTestBase.php
   @@ -311,10 +311,10 @@ public function testGetMultiple() {
   +    $this->assertTrue(isset($ret['test2']), "Existing cache id test2 is set.");
   +    $this->assertTrue(isset($ret['test3']), "Existing cache id test3 is set.");
   +    $this->assertTrue(isset($ret['test6']), "Existing cache id test6 is set.");
   +    $this->assertTrue(isset($ret['test7']), "Existing cache id test7 is set.");
   
   @@ -345,9 +345,9 @@ public function testGetMultiple() {
   +    $this->assertTrue(isset($ret['test2']), "Existing cache id test2 is set");
   +    $this->assertTrue(isset($ret['test7']), "Existing cache id test7 is set");
   +    $this->assertTrue(isset($ret['test19']), "Added cache id test19 is set");
   

   use assertArrayHasKey()?

I suggest to postpone this on #3114617: Properly deprecate methods in Drupal\FunctionalTests\AssertLegacyTrait and Drupal\KernelTests\AssertLegacyTrait, while still keeping deprecations silenced and on completion of #3128573: [meta] Replace assertions with more appropriate ones, since the sub-issues of #3128573: [meta] Replace assertions with more appropriate ones overlap with the changes here.

In particular:

#11.1 - addressed by #3132919: Replace assert*() involving equality comparison operators with assert(Not)(Equals|Same)
#11.2 - addressed by #3131807: [meta] Replace assertions involving calls to isset() with more appropriate assertions

Adding the "Deprecated assertions" tag to add this into the kanban board https://contribkanban.com/board/Deprecatedassertions

Let's see where it fails, now.

#9 + #17

On this.

New patch, taking into the refactoring also discussions from #3131807-90: [meta] Replace assertions involving calls to isset() with more appropriate assertions onwards.

I noticed that in cases of constructs like

    $view_link = $this->xpath('//div[@class="messages"]//a[contains(@href, :href)]', [':href' => 'aggregator/sources/']);
    $this->assert(isset($view_link), 'The message area contains a link to a feed');

we are in fact failing to test appropriately: $this->xpath returns an empty array here, since the xpath selector is //div[@class="messages"] and in fact since the test was written the class changed to 'messages-list'. But an empty array is set as a variable, so the test passes anyway. I corrected by changing the selector to //div[@data-drupal-messages], and using the WebAssert::elementExists method. This led to nice findings. There are probably many more cases of this, bot oos here, needs follow up. Bumping to major because we are fixing a test mishmash here.

Removed deprecation silencer and added deprecation test.

Interdiff not relevant.

One more.

Apllied patch #21 successfully

Usages of deprecated AssertLegacyTrait::assert() is replaced with assertTrue(), assertSession() and some specific methods in specific cases etc..

Reviewed overall navigation of the Drupal instance and couldn't find any issue with the application of the patch. The code replacement didn't affect the functionality

Thank you for reviews, NW for #22.

#22:

1. done
2. done
3. not done - we need to ensure that exactly one link exists here, it's within an assert helper. linkExists would return multiple instances if there are.

Filed #3167880: [meta] Convert assertions involving use of xpath to WebAssert, where possible for follow up.

Rerolled.

Committed 43fdb59 and pushed to 9.1.x. Thanks!