Closed (works as designed)
Project:
Drupal core
Version:
9.1.x-dev
Component:
phpunit
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Apr 2020 at 05:15 UTC
Updated:
18 Apr 2020 at 23:59 UTC
Jump to comment: Most recent
Comments
Comment #2
dwwBased on Slack thread with @jungle, giving this a human-readable title.
Comment #3
jungleThank you, @dww!
Comment #4
mondrakeIMHO, in this specific case the current state is better readable than the proposed to-be.
Comment #5
jungleThanks for commenting, @mondrake. Feel free to close this.
Comment #6
dwwYeah, like #3128815: Replace assert*() involving greater/less comparison operators with assert(Greater|Less)Than(OrEqual), I'm also -1 to this specific change. I think the original code is more readable and clear than the proposed replacement.
Seems unanimous, so let's close this.