Closed (fixed)
Project:
Olivero
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Apr 2020 at 10:52 UTC
Updated:
2 May 2020 at 08:07 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #2
kostyashupenkoI guess some design proposals expected here, since figma has only case with 3 tabs.
Also would be nice to review mobile tabs as well
Comment #3
shaalI don't think a new design is needed here.
On mobile there is no problem. The primary tabs are displayed vertically:

Maybe in a similar way to how the main-menu / mobile-menu is dynamically changing, according to the actual width of all menu items.
So when there's not enough space to display all tabs in primary tabs horizontally, they should be displayed vertically like in mobile.
Comment #4
mherchelYeah, we probably use something like intersection observer or resize observer to work with it.
But for it to work without JS (which would be nice), we could also just let them wrap.
Comment #5
kostyashupenkoRe #3:
Honestly i don't think it's good idea at all. We may have a case sometimes when we don't have enough space on large screens. Check screenshot:

So if we will switch it on dropdown, where tabs will be displayed like 1 tab per 1 row, it will be too wide tabs. Also i believe we have to evade js solution in all places where possible.
Re #4:
Well it doesn't look too good right now if to let them wrap. There is a mess with side borders, check screenshot:

So we need design proposals here as i said, maybe we can make these tabs less size than now, or let them wrap, but add top/bottom borders, or smth.
Comment #6
mherchelIt's never going to look good when it wraps, but it can look better. Instead of adding a background color on the parent element, we could add it on the list items themselves, and give it a slight bottom margin. Thoughts?
Comment #7
kostyashupenkoComment #8
kostyashupenko@mherchel i really like your proposed solution
Gonna manage this task
Comment #9
kostyashupenkoComment #10
duneblI would add the following:
Maybe we can differentiate a little bit more the primary and secondary tabs design. This is because, like it is, a lambda/new user will have some pain to understand the fact that primary tabs are structurally more important (like
<h1> and <h2>)Some ideas:
-Primary: Uppercase vs Secondary: Sentence case (or lowercase) [and/or font size smaller]
-Primary: background vs Secondary:no background
-Primary: vertical border vs Secondary: no border
We can also decrease some padding/margin if necessary
Comment #11
kostyashupenkoI would suggest the following:
Comment #12
duneblThis is really better! +1
Comment #13
mherchelThe patch in #9 looks good, but doesn't match the designs in #11 (#11 has a white background). Is there still work going on? I think we should move the secondary tabs task to a followup issue.

Comment #14
kostyashupenkoComment #15
kostyashupenkoReady for review.
Mobile tabs:

Desktop:

Comment #16
mherchelLooking good! Committed!