[D8] UI Styles

Thank you for applying! I added the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.

If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

At a quick review, I didn't find any security issues. There are some small coding standard issues to fix, reported from PAReview.

name: UI Styles
description: Define styles from modules and themes,.
core: 8.x
core_version_requirement: ^8 || ^9
package: User interface
type: module

Since the composer.json file is setting the minimum Drupal version to 8.8, also the .info file should report the same requirement. (core_version_requirement works also with ^8 || ^9.) (There is also a comma before the period that should be removed, in the module description.)

The LICENSE.txt file is not necessary, as any module hosted on drupal.org is licensed under the same license used by Drupal.

/**
 * Implementation of hook_element_info_alter().
 *
 */

It should be Implements hook_element_info_alter().

Found "doc" folder.
Please remove this folder. Please see attached screenshot.

Remove comma in *.info.yml file. Please see below

description: Define styles from modules and themes,.

Still some pareview issue pending :

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
8 | WARNING | Line exceeds 80 characters; contains 94 characters
9 | WARNING | Line exceeds 80 characters; contains 121 characters
14 | WARNING | Line exceeds 80 characters; contains 131 characters
16 | WARNING | Line exceeds 80 characters; contains 287 characters
17 | WARNING | Line exceeds 80 characters; contains 197 characters
18 | WARNING | Line exceeds 80 characters; contains 155 characters
19 | WARNING | Line exceeds 80 characters; contains 127 characters
27 | WARNING | Line exceeds 80 characters; contains 125 characters
60 | WARNING | Line exceeds 80 characters; contains 439 characters
--------------------------------------------------------------------------

FILE: ...view_temp/modules/ui_styles_library/ui_styles_library.links.menu.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...emp/modules/ui_styles_layout_builder/ui_styles_layout_builder.module
--------------------------------------------------------------------------
FOUND 6 ERRORS AND 4 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------
118 | ERROR | [x] Expected 1 blank line after function; 2 found
122 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
124 | ERROR | [x] Whitespace found at end of line
126 | ERROR | [x] Whitespace found at end of line
127 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
161 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
163 | ERROR | [x] Whitespace found at end of line
165 | ERROR | [x] Whitespace found at end of line
166 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
182 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 1.16 secs; Memory: 4Mb

The doc directory contains the image linked from the README.md file. Modules can have any directory they need and the Drupal coding standards don't vet the use of such directories.

Pareviewsh issue is still pending. Please fix this.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
8 | WARNING | Line exceeds 80 characters; contains 94 characters
9 | WARNING | Line exceeds 80 characters; contains 121 characters
14 | WARNING | Line exceeds 80 characters; contains 131 characters
16 | WARNING | Line exceeds 80 characters; contains 287 characters
17 | WARNING | Line exceeds 80 characters; contains 197 characters
18 | WARNING | Line exceeds 80 characters; contains 155 characters
19 | WARNING | Line exceeds 80 characters; contains 127 characters
27 | WARNING | Line exceeds 80 characters; contains 125 characters
60 | WARNING | Line exceeds 80 characters; contains 439 characters
--------------------------------------------------------------------------

FILE: ...emp/modules/ui_styles_layout_builder/ui_styles_layout_builder.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
127 | WARNING | Line exceeds 80 characters; contains 81 characters
166 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------

Time: 1.23 secs; Memory: 6Mb

I am closing this application due to lack of replies.