Problem/Motivation

When editing a page (using Olivero theme), Vertical tabs section seems not themed yet, or at least missing padding.

Steps to reproduce -

  1. Go to /admin/appearance
  2. Make Olivero the default theme.
  3. At the bottom of themes page, disable this setting - Use the administration theme when editing or creating content
  4. Edit any node

Proposed resolution

Theme vertical tabs for Olivero / add missing padding.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#12 screen-patch-12-05.png37.17 KBindrajithkb
#11 3127209-11.patch5.21 KBkostyashupenko
#8 Create Article | Drupal 8 Sandbox 2020-05-09 16-25-26.png141.83 KBjerseycheese
olivero-vertical-tabs--no-padding.png57.1 KBshaal

Comments

shaal created an issue. See original summary.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented
Issue summary: View changes
hansa11’s picture

hansa11 commented
Issue tags: +Needs design
meenakshig’s picture

meenakshig commented
Issue tags: +DIACWApril2020
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

I would honestly be happy if there was just padding around the primary form container. Maybe --sp at mobile and --sp2 at wider widths.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Assigned: Unassigned » kostyashupenko
kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Assigned: kostyashupenko » Unassigned
Status: Active » Postponed
Related issues: +#3129147: Theme details element

Unfortunately we can't start this task right now, because it needs details styling, which is here https://www.drupal.org/project/olivero/issues/3129147

Also Re #5:

I would honestly be happy if there was just padding around the primary form container.

I don't think we can deal here just with paddings. At least we have to adapt paddings, colours, hover focus active states, make clean-up for details, also grid.

Anyway postponed for now until related task is not fixed.

jerseycheese’s picture

jerseycheese
Primary language English
Location Virginia Beach, VA
commented
StatusFileSize
new Create Article | Drupal 8 Sandbox 2020-05-09 16-25-26.png141.83 KB

Checked into this, since the blocker has been cleared (https://www.drupal.org/project/olivero/issues/3129147)...

Vertical tabs still need theming - here's an example of it looking particularly broken at /node/add/article:

vertical tabs broken theming

Should we make this an active issue now?

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Postponed » Active

sure!

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Assigned: Unassigned » kostyashupenko
kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Assigned: kostyashupenko » Unassigned
Status: Active » Needs review
StatusFileSize
new 3127209-11.patch5.21 KB
indrajithkb’s picture

indrajithkb commented
StatusFileSize
new screen-patch-12-05.png37.17 KB

Hi @kostyashupenko thanks for #11 patch.

Its looking good.

screen shot

indrajithkb’s picture

indrajithkb commented
Status: Needs review » Reviewed & tested by the community
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

This looks amazing. I yanked out the underlines on focus and hover because Claro didn't have them, and I don't think they were necessary (let me know if you strongly disagree).

Fixed and committing!

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Reviewed & tested by the community » Fixed
indrajithkb’s picture

indrajithkb commented
Version: » 8.x-1.0-alpha1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.