How to reproduce:

1-open a node edit page (any one) [with the olivero theme]

2-scroll until:
a) the main menu become an hamburger menu
b) a form element is on top of the page where the menu reside by default

result: you will not be able to click/activate this form element

This is because the child div of <header id="header" class="header site-header" role="banner"> which is <div class="header__left"> is taking the full width of the page... and by this, is receiving the click event.

I think that one easy way to solve this is to set pointer-events: none; to the header__left class and, of course, doing the opposite to the child div which need to receive click event (like #site-header__inner {pointer-events: auto;})

another way is tho change the width of .header__left

Comments

DuneBL created an issue. See original summary.

dunebl’s picture

Issue summary: View changes
sd9121’s picture

Assigned: Unassigned » sd9121
kostyashupenko’s picture

I think better manage width property, instead of pointer-events: none

boulaffasae’s picture

Status: Active » Needs review
StatusFileSize
new1.75 KB

Hi sd9121, i think this issue is already assigned to you but here is a patch i worked on it this morning

Following kostyashupenko advice, i updated:

- Animating the max-width and using calc(100vw - 90px) to set the width in :not(.is-active) mode.

I'm not sure this is what you wanted.

Sorry sd9121 for misinterpreting

dunebl’s picture

Status: Needs review » Reviewed & tested by the community

I confirm that #5 apply cleanly and solve this issue

mherchel’s picture

StatusFileSize
new395 bytes

This is great work! Good find, and good fix. One minor change on commit. There's a variable defined for the 90px called --content-left. Interdiff attached.

mherchel’s picture

Status: Reviewed & tested by the community » Fixed

Committed. Thanks everyone!

sd9121’s picture

Assigned: sd9121 » Unassigned
kostyashupenko’s picture

Status: Fixed » Needs work

I have to re-open this task, since small fix required during yarn lint:css

$ yarn lint:css
yarn run v1.22.4
$ stylelint "css/src/**/*.css"

css/src/components/header.css
 64:7  ✖  Expected "width" to come before "box-shadow"   order/properties-order
kostyashupenko’s picture

By the way, don't pay your attention to `css/src/components/table.css` linting issues at this task

hansa11’s picture

Assigned: Unassigned » hansa11
Status: Needs work » Needs review
StatusFileSize
new1.51 KB

Just changed the declaration order for header.css and node-teaser.css.

Thank you @kostyashupenko for raising this up.

hansa11’s picture

Assigned: hansa11 » Unassigned
mherchel’s picture

Status: Needs review » Needs work
StatusFileSize
new293 KB
new75.64 KB

Another issue that I noticed is that when modifying the width, the menu text wraps, which is noticeable during the transition.

I'm attaching a movie of this, and also see the screencap below

hansa11’s picture

StatusFileSize
new669.4 KB
new3.2 MB

I found another issue here, while scrolling, at one point the header navigation floats towards the left.

header nav

I am also attaching the video here.

hansa11’s picture

Assigned: Unassigned » hansa11
hansa11’s picture

Assigned: hansa11 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new8.05 KB

1. Fixed the overlapping menu text wraps on transition. (#14)
2. Fixed the Header navigation floating towards the left on transition. (#15)
3. Fixed the cursor on the Site branding block when the navigation was not active. (Found it while fixing other issues)
4. After patch #5, the width of the container was growing beyond the container size on the transition, so fixed it. (On 13-inch MacBook Pro)
5. Fixed the linting issue for header.css and node-teaser.css (#10)

Please review.

hansa11’s picture

StatusFileSize
new2.47 MB

Here is the video showing the cursor issue on the Site branding block when the navigation was not active. (as mentioned in point 3 of #17).

proeung’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new7.76 KB

@hansa11 I tested your patch and everything looks great! Committing these changes and attached is a reroll based on the latest codebase. Thanks for contributing to this issue!

mherchel’s picture

The previous patch sets visibility hidden on the header, which removes the "slide out" animation. I'm going to revert the commit and re-open this.

mherchel’s picture

Status: Reviewed & tested by the community » Needs work
mherchel’s picture

StatusFileSize
new9.33 KB

Attached is an updated patch that uses pointer-events to accomplish the goal (as opposed to setting width on the container).

mherchel’s picture

Status: Needs work » Fixed

Fix committed! Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.