How to reproduce:
1-open a node edit page (any one) [with the olivero theme]
2-scroll until:
a) the main menu become an hamburger menu
b) a form element is on top of the page where the menu reside by default
result: you will not be able to click/activate this form element
This is because the child div of <header id="header" class="header site-header" role="banner"> which is <div class="header__left"> is taking the full width of the page... and by this, is receiving the click event.
I think that one easy way to solve this is to set pointer-events: none; to the header__left class and, of course, doing the opposite to the child div which need to receive click event (like #site-header__inner {pointer-events: auto;})
another way is tho change the width of .header__left
| Comment | File | Size | Author |
|---|---|---|---|
| #22 | 3127166-22.patch | 9.33 KB | mherchel |
| #19 | header_fixes-3127166-18-reroll.patch | 7.76 KB | proeung |
| #18 | issue-cursor-pointing-hidden-logo.mp4 | 2.47 MB | hansa11 |
| #17 | header_fixes-3127166-17.patch | 8.05 KB | hansa11 |
| #15 | olivero-header-navigation.mp4 | 3.2 MB | hansa11 |
Comments
Comment #2
duneblComment #3
sd9121 commentedComment #4
kostyashupenkoI think better manage width property, instead of pointer-events: none
Comment #5
boulaffasae commentedHi sd9121, i think this issue is already assigned to you but here is a patch i worked on it this morning
Following kostyashupenko advice, i updated:
- Animating the
max-widthand usingcalc(100vw - 90px)to set the width in:not(.is-active)mode.I'm not sure this is what you wanted.
Sorry sd9121 for misinterpreting
Comment #6
duneblI confirm that #5 apply cleanly and solve this issue
Comment #7
mherchelThis is great work! Good find, and good fix. One minor change on commit. There's a variable defined for the 90px called
--content-left. Interdiff attached.Comment #8
mherchelCommitted. Thanks everyone!
Comment #9
sd9121 commentedComment #10
kostyashupenkoI have to re-open this task, since small fix required during
yarn lint:cssComment #11
kostyashupenkoBy the way, don't pay your attention to `css/src/components/table.css` linting issues at this task
Comment #12
hansa11 commentedJust changed the declaration order for header.css and node-teaser.css.
Thank you @kostyashupenko for raising this up.
Comment #13
hansa11 commentedComment #14
mherchelAnother issue that I noticed is that when modifying the width, the menu text wraps, which is noticeable during the transition.
I'm attaching a movie of this, and also see the screencap below

Comment #15
hansa11 commentedI found another issue here, while scrolling, at one point the header navigation floats towards the left.
I am also attaching the video here.
Comment #16
hansa11 commentedComment #17
hansa11 commented1. Fixed the overlapping menu text wraps on transition. (#14)
2. Fixed the Header navigation floating towards the left on transition. (#15)
3. Fixed the cursor on the Site branding block when the navigation was not active. (Found it while fixing other issues)
4. After patch #5, the width of the container was growing beyond the container size on the transition, so fixed it. (On 13-inch MacBook Pro)
5. Fixed the linting issue for header.css and node-teaser.css (#10)
Please review.
Comment #18
hansa11 commentedHere is the video showing the cursor issue on the Site branding block when the navigation was not active. (as mentioned in point 3 of #17).
Comment #19
proeung@hansa11 I tested your patch and everything looks great! Committing these changes and attached is a reroll based on the latest codebase. Thanks for contributing to this issue!
Comment #20
mherchelThe previous patch sets visibility hidden on the header, which removes the "slide out" animation. I'm going to revert the commit and re-open this.
Comment #21
mherchelComment #22
mherchelAttached is an updated patch that uses pointer-events to accomplish the goal (as opposed to setting width on the container).
Comment #23
mherchelFix committed! Thanks everyone!