It would be handy if the DNS checking code was in a service that could be called from other custom modules or to build other features into this module.

CommentFileSizeAuthor
#5 check_dns.png516.53 KBgaurav_drupal
#3 3127119-3.patch2.71 KBgaurav_drupal

Comments

lolcode created an issue. See original summary.

lolcode’s picture

lolcode commented

I wrote a first draft proof of concept in another module: https://git.drupalcode.org/project/dns_check/-/tree/8.x-1.x/src%2FService

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
StatusFileSize
new 3127119-3.patch2.71 KB

I moved the logic to a service. Provided the patch.

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Status: Active » Needs review
gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new check_dns.png516.53 KB

Tested and verified the patch. Attached screenshot.

  • Gaurav_drupal committed cf47bcd on 8.x-1.x 
    Issue #3127119 by Gaurav_drupal: Move DNS check code to a service so...
gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Status: Reviewed & tested by the community » Fixed
gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Status: Fixed » Closed (fixed)