Problem/Motivation

assertAttributeSame() is deprecated and will be removed in PHPUnit 9.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3126792-4.patch2.44 KBmondrake
#2 3126792-2.patch2.48 KBmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
StatusFileSize
new 3126792-2.patch2.48 KB

In this case it's preferrable to use reflection IMO

Status: Needs review » Needs work

The last submitted patch, 2: 3126792-2.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new 3126792-4.patch2.44 KB
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

All test code changes look good to me.
By removing the line from the ignored warnings that are thrown by PHPUnit 8, we have testing that all cases of the use of the method are removed.
For me it is RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 5228b8df1c to 9.1.x and 38f08f8bb4 to 9.0.x. Thanks!

I agree that no BC layer for 8.9.x is warranted because we can you reflection there too.

  • alexpott committed 5228b8d on 9.1.x 
    Issue #3126792 by mondrake: Replace usage of assertAttributeSame() that...

  • alexpott committed 38f08f8 on 9.0.x 
    Issue #3126792 by mondrake: Replace usage of assertAttributeSame() that...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.