\Drupal\ban\Plugin\migrate\destination\BlockedIP is not identical with its filename BlockedIp.php

The use statement in DestinationCategoryTest needs to be changed from BlockedIP to BlockedIp. And then I did a grep for 'BlockedIP' and changed other references. It made sense to me to do it all at once but others may consider it out of scope. Therefore, this patch is only for 9.1.x.

While "Ip" might look wrong this is the correct way to camel case acronyms and initialisms. I think #5 is OK to fix all instances in one go.

Committed aafcd8d and pushed to 9.1.x. Thanks!

Going too ask release managers about backporting this.

+++ b/core/modules/migrate_drupal/tests/src/Kernel/Plugin/migrate/DestinationCategoryTest.php
@@ -2,7 +2,7 @@
-use Drupal\ban\Plugin\migrate\destination\BlockedIP;
+use Drupal\ban\Plugin\migrate\destination\BlockedIp;

Need to fix \Drupal\Tests\migrate_drupal\Kernel\Plugin\migrate\DestinationCategoryTest::getContentClasses() to use the correct case. Fixed on commit.

We have to fix all these things together as this fixes odd bugs on case sensitive file systems...

Psy Shell v0.10.3 (PHP 7.3.13 — cli) by Justin Hileman
>>> class_exists('Drupal\ban\Plugin\migrate\destination\BlockedIP')
=> false
>>> class_exists('Drupal\ban\Plugin\migrate\destination\BlockedIp')
=> true
>>> class_exists('Drupal\ban\Plugin\migrate\destination\BlockedIP')
=> true

Note this doesn't really break much because of the way we discover plugins.

@jungle yes that's unnecessary if the patch applies to all the branches you can leave it up to the committer. That said it can be helpful to queue test runs against the other branches.

Discussed with @catch and we agreed to backport to 9.0.x and 8.9.x.

In #3134472: [8.8 only] Fix failure of enabled phpcs rule: Drupal.Files.EndFileNewline in 8.8.x @jungle discussed backporting this fix to 8.8.x. If it had just been a test class, a backport would have been alright, but since this is an actual public API, case-insensitive filesystems would have had to change their use statements for this (and case-sensitive ones would presumably have already worked around the problem, and even if they didn't it's only a difference of a less than month between the release of 8.8.6 and that of 8.9.0 for the bugfix to be available for them).

So, leaving this against 8.9.x is correct.