The informational variant of the messages has low contrast. It has the CSS class of .messages.messages--info

CommentFileSizeAuthor
#6 interdiff_4-6.txt5.08 KBkostyashupenko
#6 3126706-6.patch17.64 KBkostyashupenko
#5 3126706-4.patch15.28 KBmherchel
#4 3126706-4.patch0 bytesmherchel
#4 3126706-4-interdiff.patch4.2 KBmherchel
#3 3126706-2.patch12.58 KBkostyashupenko
#2 Снимок экрана 2020-04-13 в 15.55.41.png111.39 KBkostyashupenko
#2 3126706-2.patch12.68 KBkostyashupenko
Registration___Olivero.png78.44 KBmherchel

Comments

mherchel created an issue. See original summary.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Needs review
StatusFileSize
new 3126706-2.patch12.68 KB
new Снимок экрана 2020-04-13 в 15.55.41.png111.39 KB

Messages

1. low contrast comes from webform module (link). It is contrib module and we shouldn't override its styles in Olivero.
2. added "info" type icon (question icon, blue color)
3. fixed styles: alignment of icons and text
4. reworked js: querySelectorAll().forEach() is not working in IE properly, so i replaced it by Array.prototype.forEach.call(). Also removed some aria attributes.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
StatusFileSize
new 3126706-2.patch12.58 KB

Use this patch

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3126706-4-interdiff.patch4.2 KB
new 3126706-4.patch0 bytes

This is looking good!

I figured out the issue why the nodelist.forEach polyfill wasn't working is because I modified it when fixing linting errors. This patch fixes that.

I also removed an unused rss.svg file, and added a rule to set background-image none on the messages (to override webform and any other modules).

Updated patch and interdiff attached!

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3126706-4.patch15.28 KB

Didn't generate the full patch properly. Correct patch attached.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
StatusFileSize
new 3126706-6.patch17.64 KB
new interdiff_4-6.txt5.08 KB 
+  /* Additional specificity to override contrib modules. */
+  &.messages-list__item {
+    background-image: none;
+  }

Honestly i disagree totally to have such overrides. It is issue of contrib modules, so should be fixed there. We shouldn't care about all possible and impossible cases in drupal, which are not related to the core, isn't it ? )

Btw i have tested your patch in IE11 @mherchel and all is fine now there with forEach

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

Honestly i disagree totally to have such overrides. It is issue of contrib modules, so should be fixed there. We shouldn't care about all possible and impossible cases in drupal, which are not related to the core, isn't it ? )

I can definitely see that point.

On the other hand, webform is pretty popular, and it's not a big deal to implement this. I read somewhere that Microsoft tested Windows 95 on a variety of popular Windows 3.1 applications and games, and modified the OS to suit these popular games, so that from the end user's perspective, things "just worked".

I don't mind doing things like this if the 1) module is popular, and 2) if the fix is easy and documented in code comments.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Reviewed & tested by the community » Fixed

Committed! Once again, thanks for the hard work @kostyashupenko!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.