Typo - <me> instead of <em> - in field_ui.add_field.html.twig and field_ui.reference_field.html.twig

This causes three problems:

  1. The marked up text isn't set in italic - obviously
  2. When translators copy the source text with markup, and then translate without fixing the HTML, you get warnings about invalid HTML when importing
  3. and the text isn't translated

Patch coming up.

CommentFileSizeAuthor
#2 help_topics-invalid-html-3126617-2.patch3.19 KBhansfn

Comments

hansfn created an issue. See original summary.

hansfn’s picture

hansfn commented
StatusFileSize
new help_topics-invalid-html-3126617-2.patch3.19 KB
abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Component: user interface text » help.module
Status: Active » Reviewed & tested by the community
Related issues: +#3087562: Convert datetime, datetime_range, field, field_ui, link, options, telephone, text modules hook_help() to topic(s)

Patch looks good to me.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

  • xjm committed 22b08be on 9.1.x 
    Issue #3126617 by hansfn: Invalid HTML for Field UI in Help Topics...

  • xjm committed ab45191 on 9.0.x 
    Issue #3126617 by hansfn: Invalid HTML for Field UI in Help Topics...

  • xjm committed 8433377 on 8.9.x 
    Issue #3126617 by hansfn: Invalid HTML for Field UI in Help Topics...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Nice catch! Committed to 9.1.x, 9.0.x, and 8.9.x as a beta-eligible string change. (It's not backportable to 8.8.x because it would break translations of this string.)

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.