FILE: ...mpp/htdocs/drupal/modules/addevent/src/Plugin/Block/AddToCalendarBlock.php
--------------------------------------------------------------------------------
FOUND 9 ERRORS AND 24 WARNINGS AFFECTING 33 LINES
--------------------------------------------------------------------------------
7 | WARNING | [x] Unused use statement
8 | WARNING | [x] Unused use statement
9 | WARNING | [x] Unused use statement
18 | ERROR | [ ] Missing short description in doc comment
30 | ERROR | [ ] Missing short description in doc comment
35 | ERROR | [ ] Missing short description in doc comment
82 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
103 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'OPAQUE'
120 | ERROR | [x] Closing parenthesis of array declaration must be on a new
| | line
140 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
211 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: TRUE
212 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
213 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
249 | WARNING | [x] A comma should follow the last multiline array item.
| | Found:
| | 'https://www.textmagic.com/free-tools/rrule-generator'
482 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $providerLabel
505 | WARNING | [ ] Possible useless method overriding detected
536 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
537 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
538 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
574 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
584 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
585 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
603 | ERROR | [x] Expected 1 space after "="; 0 found
646 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 0
652 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 0
658 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 0
663 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 0
669 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 0
675 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 0
680 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 0
708 | ERROR | [x] Data types in @return tags need to be fully namespaced
723 | ERROR | [x] Expected 1 blank line after function; 0 found
724 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------------

FILE: /opt/lampp/htdocs/drupal/modules/addevent/templates/addevent.theme
------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------
13 | ERROR | Missing parameter type
------------------------------------------------------------------------

FILE: /opt/lampp/htdocs/drupal/modules/addevent/addevent.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
17 | WARNING | [x] A comma should follow the last multiline array item. Found:
| | 'add-to-calendar-button'
--------------------------------------------------------------------------------

FILE: /opt/lampp/htdocs/drupal/modules/addevent/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
12 | WARNING | Line exceeds 80 characters; contains 196 characters
31 | WARNING | Line exceeds 80 characters; contains 88 characters
----------------------------------------------------------------------

CommentFileSizeAuthor
#4 interdiff_3126536-3.txt548 bytesgaurav_drupal
#4 3126536-4.patch11.5 KBgaurav_drupal
#2 3126536-2.patch11.17 KBneelam_wadhwani

Comments

neelam_wadhwani created an issue. See original summary.

neelam_wadhwani’s picture

neelam_wadhwani commented
Assigned: neelam_wadhwani » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3126536-2.patch11.17 KB

Kindly review patch.

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Assigned: Unassigned » gaurav_drupal
Status: Needs review » Needs work

Thanks for the patch. But patch doesn't resolve the following issue:

FILE: addevent/src/Plugin/Block/AddToCalendarBlock.php
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 509 | WARNING | Possible useless method overriding detected
------------------------------------------------------------------------------------------------------------------
gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Assigned: gaurav_drupal » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3126536-4.patch11.5 KB
new interdiff_3126536-3.txt548 bytes

Please review the interdiff and patch.