Closed (fixed)
Project:
Olivero
Component:
Code
Priority:
Major
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
8 Apr 2020 at 07:16 UTC
Updated:
25 Apr 2020 at 01:59 UTC
Jump to comment: Most recent, Most recent file
yarn lint:css and yarn lint:js commands are not working properly.
- We need to follow coding standards from drupal core, so add stylelint/eslint/prettier configs from core into the theme.
- Fix and recompile all styles/scripts.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3125908-2.patch | 821.54 KB | kostyashupenko |
Comments
Comment #2
kostyashupenko1. Added
.eslintignore,.eslintrc.json,.eslintrc.passing.json,.prettierrc.jsonand.stylelintrc.jsonconfigs to theme. It is fully based on drupal core configs.2. Fixed absolutely all errors and warnings of all css/js. 99% of those errors were related to the order/whitespaces/linebreaks, for 1% of other errors/warnings i did some changes in code manually, like: move js function on top, or replace
==by===, or replacefunction () {}by() => {}or smth like this. It was minor changes i did, so i tried to not break anything.Now no errors in code:
What was additionally done:
1. Removed
package-lock.json- we don't need it. We have and useyarn.lock2. Added cool command
yarn lint-fixwhich will fix your code automatically, based on linters. Updated alsoREADME.md. So before your patch you just need to runyarn lint-fixComment #3
mherchelThis is amazing! Thank for the hard work.
I committed the config files, and then the CSS changes.
I have yet to commit the JS changes... I want to QA those more thoroughly.
I'll leave this in needs review until I do the review of the JS
Comment #4
mherchelCommitted earlier today!