t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead

CommentFileSizeAuthor
#13 3125645-13.patch15.96 KBkhiminrm
#10 3125645-10.patch15.46 KBneelam_wadhwani
#8 interdiff_6-8.txt610 bytesneelam_wadhwani
#8 3125645-8.patch14.49 KBneelam_wadhwani
#6 3125645-6.patch14.1 KBneelam_wadhwani
#3 3125645-2.patch7.13 KBprabha1997

Issue fork commerce_shipping-3125645

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

neelam_wadhwani created an issue. See original summary.

prabha1997’s picture

prabha1997 commented
Assigned: neelam_wadhwani » Unassigned
Status: Needs work » Needs review

Kindly review patch

prabha1997’s picture

prabha1997 commented
StatusFileSize
new 3125645-2.patch7.13 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3125645-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

neelam_wadhwani’s picture

neelam_wadhwani commented
Assigned: Unassigned » neelam_wadhwani
neelam_wadhwani’s picture

neelam_wadhwani commented
StatusFileSize
new 3125645-6.patch14.1 KB

Kindly review patch.

neelam_wadhwani’s picture

neelam_wadhwani commented
Assigned: neelam_wadhwani » Unassigned
Status: Needs work » Needs review
neelam_wadhwani’s picture

neelam_wadhwani commented
StatusFileSize
new 3125645-8.patch14.49 KB
new interdiff_6-8.txt610 bytes

Status: Needs review » Needs work

The last submitted patch, 8: 3125645-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

neelam_wadhwani’s picture

neelam_wadhwani commented
StatusFileSize
new 3125645-10.patch15.46 KB
neelam_wadhwani’s picture

neelam_wadhwani commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: 3125645-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

khiminrm’s picture

khiminrm commented
StatusFileSize
new 3125645-13.patch15.96 KB

Fixed test and coding standards issues.

khiminrm’s picture

khiminrm commented
Status: Needs work » Needs review
anabpv’s picture

anabpv
she/her
Location Portugal 🇵🇹
commented
Assigned: Unassigned » anabpv

I will review this

anabpv opened merge request !12

anabpv’s picture

anabpv
she/her
Location Portugal 🇵🇹
commented
Assigned: anabpv » Unassigned

Steps performed:
1 - downloaded the module and ran phpcs
2 - identified and corrected the t() calls
3 - opened an MR and committed the changes

Waiting for review

chakkche’s picture

chakkche commented
Assigned: Unassigned » chakkche

I will review this

chakkche’s picture

chakkche commented
Assigned: chakkche » Unassigned
Status: Needs review » Reviewed & tested by the community

Steps performed to review

  • Downloaded the forked code
  • Ran Phpcs

Found no t() calls issues. So marking this as RTBC

andregp’s picture

andregp commented
Status: Reviewed & tested by the community » Needs work

Needs to address the MR comments after #19.
Please remove the unnecessary added traits.

chakkche’s picture

chakkche commented
Assigned: Unassigned » chakkche
chakkche’s picture

chakkche commented
Assigned: chakkche » Unassigned
Status: Needs work » Needs review
jsacksick’s picture

jsacksick commented

Why did we need to do more work since the patch from #13? Looks like we already had most of the calls (if not all) fixed?

  • jsacksick committed 957971c on 8.x-2.x authored by khiminrm 
    Issue #3125645 by neelam_wadhwani, chakkche, anabpv, khiminrm,...
jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Committed a slightly different patch, thanks everyone!

  • jsacksick committed d9b57ce on 8.x-2.x 
    Issue #3125645 followup: Fix the duplicated use statement.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.